Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate font-variation-settings descriptor with stylo #20042

Merged
merged 1 commit into from Feb 14, 2018
Merged

Integrate font-variation-settings descriptor with stylo #20042

merged 1 commit into from Feb 14, 2018

Conversation

@upsuper
Copy link
Member

upsuper commented Feb 13, 2018 •
edited by SimonSapin

This is the Servo side change for bug 1435984.

This change is Reviewable
@highfive
Copy link

highfive commented Feb 13, 2018

Heads up! This PR modifies the following files:

  • @bholley: ports/geckolib/glue.rs, components/style/gecko/generated/structs.rs, components/style/gecko/generated/bindings.rs, components/style/gecko_bindings/sugar/ns_css_value.rs, components/style/font_face.rs and 1 more
  • @canaltinova: components/style/gecko/generated/structs.rs, components/style/gecko/generated/bindings.rs, components/style/gecko_bindings/sugar/ns_css_value.rs, components/style/font_face.rs, components/style/gecko/rules.rs
  • @emilio: ports/geckolib/glue.rs, components/style/gecko/generated/structs.rs, components/style/gecko/generated/bindings.rs, components/style/gecko_bindings/sugar/ns_css_value.rs, components/style/font_face.rs and 1 more
@highfive
Copy link

highfive commented Feb 13, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@upsuper
Copy link
Member Author

upsuper commented Feb 13, 2018

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2018

📌 Commit d676b09 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2018

⌛ Testing commit d676b09 with merge 882c94b...
bors-servo added a commit that referenced this pull request Feb 13, 2018
@bors-servo
Auto merge of #20042 - upsuper:font-variation-desc, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
882c94b 
Integrate font-variation-settings descriptor with stylo

This is the Servo side change for [bug 1435984](https://bugzilla.mozilla.org/show_bug.cgi?id=1435984).
@upsuper
Copy link
Member Author

upsuper commented Feb 13, 2018

@bors-servo p=1
@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2018

💔 Test failed - linux-dev
@upsuper
Copy link
Member Author

upsuper commented Feb 14, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2018

⚡ Previous build results for android, arm64, linux-rel-wpt, mac-dev-unit are reusable. Rebuilding only arm32, linux-dev, linux-rel-css, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev...
@upsuper
Copy link
Member Author

upsuper commented Feb 14, 2018 

LLVM ERROR: IO failure on output stream.
error: Could not compile `geckoservo`.

...?
@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2018

💔 Test failed - linux-rel-css
@bholley
Copy link
Contributor

bholley commented Feb 14, 2018 

thread 'bindings::root::bindgen_test_layout_nsCSSFontFaceRule' panicked at 'assertion failed: `(left == right)`

left: 256,
right: 240: Size of: nsCSSFontFaceRule', /home/servo/buildbot/slave/linux-rel-css/build/target/geckolib/release/build/style-4b43331712e911df/out/gecko/structs.rs:37619:8
@upsuper
Integrate font-variation-settings descriptor with stylo
Loading status checks…
6ffa888
@upsuper upsuper force-pushed the upsuper-forks:font-variation-desc branch from d676b09 to 6ffa888 Feb 14, 2018
@upsuper
Copy link
Member Author

upsuper commented Feb 14, 2018

@bors-servo retry
@upsuper
Copy link
Member Author

upsuper commented Feb 14, 2018

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2018

📌 Commit 6ffa888 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2018

⌛ Testing commit 6ffa888 with merge 27cd4f7...
bors-servo added a commit that referenced this pull request Feb 14, 2018
@bors-servo
Auto merge of #20042 - upsuper:font-variation-desc, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
27cd4f7 
Integrate font-variation-settings descriptor with stylo

This is the Servo side change for [bug 1435984](https://bugzilla.mozilla.org/show_bug.cgi?id=1435984).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20042)
<!-- Reviewable:end -->
@upsuper
Copy link
Member Author

upsuper commented Feb 14, 2018

Manual adjusting binding files is hard :/ I probably should copy that from try server and rustfmt it from the beginning... I didn't do that because I need to run rustfmt for it, and rustfmt reports errors... maybe it's not that bad I guess...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2018

💔 Test failed - linux-rel-wpt
@upsuper
Copy link
Member Author

upsuper commented Feb 14, 2018 •
edited

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2018

⚡ Previous build results for android, arm32, linux-dev, linux-rel-css, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only arm64, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt4...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2018

⚡ Previous build results for android, arm32, linux-dev, linux-rel-css, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only arm64, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt4...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 27cd4f7 to master...
@bors-servo bors-servo merged commit 6ffa888 into servo:master Feb 14, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@upsuper upsuper deleted the upsuper-forks:font-variation-desc branch Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@upsuper @highfive @bors-servo @bholley @emilio
You can’t perform that action at this time.