Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some font code around #20047

Merged
merged 4 commits into from Feb 15, 2018
Merged

Move some font code around #20047

merged 4 commits into from Feb 15, 2018

Conversation

@nox
Copy link
Member

nox commented Feb 14, 2018 •
edited by SimonSapin

The only notable change is that KeywordInfo is now generic.

This change is Reviewable
@highfive
Copy link

highfive commented Feb 14, 2018

Heads up! This PR modifies the following files:

  • @bholley: components/style/stylesheets/font_feature_values_rule.rs, components/style/properties/gecko.mako.rs, ports/geckolib/glue.rs, components/style/values/specified/font.rs, components/style/values/generics/font.rs and 6 more
  • @canaltinova: components/style/stylesheets/font_feature_values_rule.rs, components/style/properties/gecko.mako.rs, components/style/values/specified/font.rs, components/style/values/generics/font.rs, components/style/values/computed/font.rs and 5 more
  • @emilio: components/style/stylesheets/font_feature_values_rule.rs, components/style/properties/gecko.mako.rs, ports/geckolib/glue.rs, components/style/values/specified/font.rs, components/style/values/generics/font.rs and 6 more
@highfive
Copy link

highfive commented Feb 14, 2018

warning Warning warning

  • These commits modify style and gfx code, but no tests are modified. Please consider adding a test!
@emilio
emilio approved these changes Feb 14, 2018
View changes
Copy link
Member

emilio left a comment

rs=me

Just for the record, the KeywordInfo change is because of:

15:20 <emilio> nox: why did keywordinfo become generic?
15:21 <nox> emilio: Because I plan to make NonNegativeLength animate as Length.
15:22 <nox> emilio: TL;DR if I want to continue #20040 I need to clean a dozen rabbit holes.
@jdm
Copy link
Member

jdm commented Feb 14, 2018

TravisCI shows several build errors.
@nox
Copy link
Member Author

nox commented Feb 14, 2018

Oops, I only ran check-geckolib. Will fix them.
@nox nox force-pushed the derive-all-the-things branch from 04155bc to ee8690a Feb 15, 2018
@emilio
emilio approved these changes Feb 15, 2018
View changes
@nox
Copy link
Member Author

nox commented Feb 15, 2018

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2018

📌 Commit ee8690a has been approved by emilio
@highfive highfive assigned emilio and unassigned KiChjang Feb 15, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2018

⌛ Testing commit ee8690a with merge daa61ac...
bors-servo added a commit that referenced this pull request Feb 15, 2018
@bors-servo
Auto merge of #20047 - servo:derive-all-the-things, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
daa61ac 
Move some font code around

The only notable change is that KeywordInfo is now generic.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20047)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2018

💔 Test failed - linux-dev
nox added 4 commits Feb 15, 2018
@nox
Move FontTag to the generic module
aea66a9
@nox
Make KeywordInfo generic
b17fea1
@nox
Properly implement ToAnimatedZero for BorderSpacing
52f0fca
@nox
Animate NonNegativeLength as its inner type
Loading status checks…
d8c43ac
@nox nox force-pushed the derive-all-the-things branch from ee8690a to d8c43ac Feb 15, 2018
@nox
Copy link
Member Author

nox commented Feb 15, 2018

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2018

📌 Commit d8c43ac has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2018

⌛ Testing commit d8c43ac with merge 0baab06...
bors-servo added a commit that referenced this pull request Feb 15, 2018
@bors-servo
Auto merge of #20047 - servo:derive-all-the-things, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0baab06 
Move some font code around

The only notable change is that KeywordInfo is now generic.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20047)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 0baab06 to master...
@bors-servo bors-servo merged commit d8c43ac into master Feb 15, 2018
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Feb 15, 2018
Closed
4 of 5 tasks complete
@SimonSapin SimonSapin deleted the derive-all-the-things branch Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @highfive @jdm @bors-servo @emilio @KiChjang
You can’t perform that action at this time.