Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clipboard related dependencies to use xcb 0.8 #20067

Merged
merged 1 commit into from Feb 23, 2018
Merged

Update clipboard related dependencies to use xcb 0.8 #20067

merged 1 commit into from Feb 23, 2018

Conversation

@Eijebong
Copy link
Member

Eijebong commented Feb 17, 2018 •
edited by SimonSapin

See rtbo/rust-xcb#55

This change is Reviewable
@nox
Copy link
Member

nox commented Feb 17, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 17, 2018

📌 Commit 9d2f828 has been approved by nox
@highfive highfive assigned nox and unassigned glennw Feb 17, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Feb 17, 2018

⌛ Testing commit 9d2f828 with merge 2ad22dc...
bors-servo added a commit that referenced this pull request Feb 17, 2018
@bors-servo
Auto merge of #20067 - Eijebong:clipboard, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2ad22dc 
Update clipboard related dependencies to use xcb 0.8

See rtbo/rust-xcb#55

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20067)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 17, 2018

💔 Test failed - android
@Eijebong
Copy link
Member Author

Eijebong commented Feb 17, 2018

Failure seems legit

/home/servo/android/ndk/r12b/android-ndk-r12b/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld.gold: error: cannot find -lxcb

No idea how to fix that though
@Eijebong
Copy link
Member Author

Eijebong commented Feb 17, 2018

aweinstock314/rust-clipboard#52
@nox
Copy link
Member

nox commented Feb 19, 2018

I'm confused, why wasn't it an issue before the bump?
@Eijebong
Copy link
Member Author

Eijebong commented Feb 19, 2018

I have no idea...
@Eijebong Eijebong force-pushed the Eijebong:clipboard branch from d9462f2 to 218fac3 Feb 19, 2018
@Eijebong
Copy link
Member Author

Eijebong commented Feb 19, 2018

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Feb 19, 2018

@Eijebong: 🔑 Insufficient privileges: and not in try users
@nox
Copy link
Member

nox commented Feb 19, 2018

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Feb 19, 2018

⌛ Trying commit 218fac3 with merge fc6d797...
bors-servo added a commit that referenced this pull request Feb 19, 2018
@bors-servo
Auto merge of #20067 - Eijebong:clipboard, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fc6d797 
Update clipboard related dependencies to use xcb 0.8

See rtbo/rust-xcb#55

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20067)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 19, 2018

💔 Test failed - linux-rel-wpt
@Eijebong
Copy link
Member Author

Eijebong commented Feb 19, 2018

That error is unrelated and reverting that commit makes the android build work again
@CYBAI
Copy link
Collaborator

CYBAI commented Feb 20, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2018

⌛ Trying commit 218fac3 with merge 6220cb3...
@Eijebong
Update clipboard related dependencies to use xcb 0.8
Loading status checks…
606a084
@Eijebong Eijebong force-pushed the Eijebong:clipboard branch from 20144b6 to 606a084 Feb 22, 2018
@nox
Copy link
Member

nox commented Feb 23, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 23, 2018

📌 Commit 606a084 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Feb 23, 2018

⌛ Testing commit 606a084 with merge bfebe57...
bors-servo added a commit that referenced this pull request Feb 23, 2018
@bors-servo
Auto merge of #20067 - Eijebong:clipboard, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bfebe57 
Update clipboard related dependencies to use xcb 0.8

See rtbo/rust-xcb#55

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20067)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 23, 2018

💔 Test failed - windows-msvc-dev
@jdm
Copy link
Member

jdm commented Feb 23, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 23, 2018

⌛ Testing commit 606a084 with merge 18f2ed9...
bors-servo added a commit that referenced this pull request Feb 23, 2018
@bors-servo
Auto merge of #20067 - Eijebong:clipboard, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
18f2ed9 
Update clipboard related dependencies to use xcb 0.8

See rtbo/rust-xcb#55

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20067)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 23, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Feb 23, 2018

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 23, 2018

⌛ Testing commit 606a084 with merge 64a4dfb...
bors-servo added a commit that referenced this pull request Feb 23, 2018
@bors-servo
Auto merge of #20067 - Eijebong:clipboard, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
64a4dfb 
Update clipboard related dependencies to use xcb 0.8

See rtbo/rust-xcb#55

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20067)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 23, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing 64a4dfb to master...
@bors-servo bors-servo merged commit 606a084 into servo:master Feb 23, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Feb 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@Eijebong @nox @bors-servo @CYBAI @jdm @glennw @highfive
You can’t perform that action at this time.