Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse a false value that is valid Python, not just JSON. #20076
Closed
Conversation
This avoids a problem with the upcoming WPT downstream sync caused by web-platform-tests/wpt@cb2d75f.
|
Opened new PR for upstreamable changes. Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#30. |
|
Since it's a holiday and I want to get this in before the next nightly build, I'm going to self-r+ this. @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 19, 2018
Use a false value that is valid Python, not just JSON. web-platform-tests/wpt@cb2d75f makes this dictionary be interpreted as Python values, not interpolated via JSON. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20076) <!-- Reviewable:end -->
|
|
|
Sigh. Can't be done before the sync that brings in web-platform-tests/wpt@cb2d75f, and can't easily be done as part of that sync :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedFeb 19, 2018
•
edited by SimonSapin
web-platform-tests/wpt@cb2d75f makes this dictionary be interpreted as Python values, not interpolated via JSON.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is