Replace IntegerOrAuto with ZIndex #20079

nox · 2018-02-20T09:15:00Z

It's its only use.

This change is

highfive · 2018-02-20T09:15:05Z

Heads up! This PR modifies the following files:

@bholley: components/style/values/computed/position.rs, components/style/properties/data.py, components/style/values/specified/mod.rs, components/style/values/computed/mod.rs, components/style/properties/gecko.mako.rs and 3 more
@canaltinova: components/style/values/computed/position.rs, components/style/properties/data.py, components/style/values/specified/mod.rs, components/style/values/computed/mod.rs, components/style/properties/gecko.mako.rs and 3 more
@emilio: components/style/values/computed/position.rs, components/style/properties/data.py, components/style/values/specified/mod.rs, components/layout/fragment.rs, components/style/values/computed/mod.rs and 4 more

highfive · 2018-02-20T09:15:06Z

Warning

These commits modify style and layout code, but no tests are modified. Please consider adding a test!

emilio · 2018-02-20T09:16:18Z

components/style/values/generics/position.rs

+    /// Returns whether `self` is `auto`.
+    #[inline]
+    pub fn is_auto(self) -> bool {
+        match self {


nit: matches!?

nox · 2018-02-20T09:17:59Z

@bors-servo r=emilio

bors-servo · 2018-02-20T09:17:59Z

📌 Commit fd55d82 has been approved by emilio

bors-servo · 2018-02-20T09:18:04Z

⌛ Testing commit fd55d82 with merge 67957c4...


        Auto merge of #20079 - servo:ZEH-INDEX, r=emilio

Replace IntegerOrAuto with ZIndex It's its only use.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20079)

bors-servo · 2018-02-20T09:33:58Z

💔 Test failed - mac-rel-wpt1

nox · 2018-02-20T13:03:34Z

@bors-servo r=emilio #JustInfraThings

bors-servo · 2018-02-20T13:03:35Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: #20078

bors-servo · 2018-02-20T13:03:35Z

📌 Commit fd55d82 has been approved by emilio

bors-servo · 2018-02-20T13:13:26Z

⌛ Testing commit fd55d82 with merge 9bee640...


        Auto merge of #20079 - servo:ZEH-INDEX, r=emilio

Replace IntegerOrAuto with ZIndex It's its only use.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20079)

bors-servo · 2018-02-20T13:43:45Z

💔 Test failed - linux-rel-css


        Replace IntegerOrAuto with ZIndex

It's its only use.

nox · 2018-02-20T14:19:17Z

Oops, I can't do negation.

@bors-servo r=emilio

bors-servo · 2018-02-20T14:19:18Z

📌 Commit b44ffcf has been approved by emilio

bors-servo · 2018-02-20T14:22:26Z

⌛ Testing commit b44ffcf with merge edb2890...


        Auto merge of #20079 - servo:ZEH-INDEX, r=emilio

Replace IntegerOrAuto with ZIndex It's its only use.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20079)

bors-servo · 2018-02-20T14:52:11Z

💔 Test failed - linux-rel-wpt

CYBAI · 2018-02-20T15:09:36Z

{"status": "FAIL", "group": "default", "message": "child.document.querySelector(...) is null", "stack": "onload/<@http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-abort/javascript-url-abort-return-value-undefined.tentative.html:18:7\nTest.prototype.step_timeout/<@http://web-platform.test:8000/resources/testharness.js:1552:20\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1494:20\nTest.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1518:20\n", "subtest": "Not aborting fetch for javascript:undefined navigation", "test": "/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-abort/javascript-url-abort-return-value-undefined.tentative.html", "line": 133269, "action": "test_result", "expected": "TIMEOUT"}
{"status": "OK", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-abort/javascript-url-abort-return-value-undefined.tentative.html", "line": 133270, "action": "test_result", "expected": "TIMEOUT"}

CYBAI · 2018-02-20T15:14:49Z

@bors-servo retry #20084

bors-servo · 2018-02-20T15:26:39Z

⌛ Testing commit b44ffcf with merge a1dd2d0...


        Auto merge of #20079 - servo:ZEH-INDEX, r=emilio

Replace IntegerOrAuto with ZIndex It's its only use.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20079)

bors-servo · 2018-02-20T15:36:15Z

💔 Test failed - mac-dev-unit

jdm · 2018-02-20T17:13:36Z

@bors-servo retry

#20087

bors-servo · 2018-02-20T17:13:41Z

⌛ Testing commit b44ffcf with merge 05b8ba0...


        Auto merge of #20079 - servo:ZEH-INDEX, r=emilio

Replace IntegerOrAuto with ZIndex It's its only use.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20079)

bors-servo · 2018-02-20T18:05:19Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 05b8ba0 to master...

highfive assigned jdm Feb 20, 2018

highfive added the S-awaiting-review label Feb 20, 2018

emilio approved these changes Feb 20, 2018

View changes

components/style/values/generics/position.rs Outdated

/// Returns whether `self` is `auto`.

#[inline]

pub fn is_auto(self) -> bool {

match self {

This comment has been minimized.

Sign in to view

emilio Feb 20, 2018
Member

nit: matches!?

nox force-pushed the ZEH-INDEX branch from d077e1d to fd55d82 Feb 20, 2018

highfive assigned emilio and unassigned jdm Feb 20, 2018

highfive added S-awaiting-merge and removed S-awaiting-review labels Feb 20, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Feb 20, 2018

highfive added S-awaiting-merge and removed S-tests-failed labels Feb 20, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Feb 20, 2018

Replace IntegerOrAuto with ZIndex

Loading status checks…

b44ffcf

It's its only use.

nox force-pushed the ZEH-INDEX branch from fd55d82 to b44ffcf Feb 20, 2018

highfive removed the S-tests-failed label Feb 20, 2018

highfive added the S-awaiting-review label Feb 20, 2018

highfive added S-awaiting-merge and removed S-awaiting-review labels Feb 20, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Feb 20, 2018

highfive added S-awaiting-merge and removed S-tests-failed labels Feb 20, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Feb 20, 2018

highfive added S-awaiting-merge and removed S-tests-failed labels Feb 20, 2018

highfive removed the S-awaiting-merge label Feb 20, 2018

SimonSapin deleted the ZEH-INDEX branch Mar 5, 2018

servo / servo

Replace IntegerOrAuto with ZIndex #20079

Replace IntegerOrAuto with ZIndex #20079

nox commented Feb 20, 2018 •

edited by SimonSapin

highfive commented Feb 20, 2018

highfive commented Feb 20, 2018

This comment has been minimized.

nox commented Feb 20, 2018

bors-servo commented Feb 20, 2018

bors-servo commented Feb 20, 2018

bors-servo commented Feb 20, 2018

nox commented Feb 20, 2018

bors-servo commented Feb 20, 2018

bors-servo commented Feb 20, 2018

bors-servo commented Feb 20, 2018

bors-servo commented Feb 20, 2018

nox commented Feb 20, 2018

bors-servo commented Feb 20, 2018

bors-servo commented Feb 20, 2018

bors-servo commented Feb 20, 2018

CYBAI commented Feb 20, 2018

CYBAI commented Feb 20, 2018

bors-servo commented Feb 20, 2018

bors-servo commented Feb 20, 2018

jdm commented Feb 20, 2018

bors-servo commented Feb 20, 2018

bors-servo commented Feb 20, 2018

servo / servo

Join GitHub today

Replace IntegerOrAuto with ZIndex #20079

Replace IntegerOrAuto with ZIndex #20079

Conversation

nox commented Feb 20, 2018 • edited by SimonSapin

highfive commented Feb 20, 2018

highfive commented Feb 20, 2018

This comment has been minimized.

emilio Feb 20, 2018

nox commented Feb 20, 2018

bors-servo commented Feb 20, 2018

bors-servo commented Feb 20, 2018

bors-servo commented Feb 20, 2018

nox commented Feb 20, 2018

bors-servo commented Feb 20, 2018

bors-servo commented Feb 20, 2018

bors-servo commented Feb 20, 2018

bors-servo commented Feb 20, 2018

nox commented Feb 20, 2018

bors-servo commented Feb 20, 2018

bors-servo commented Feb 20, 2018

bors-servo commented Feb 20, 2018

CYBAI commented Feb 20, 2018

CYBAI commented Feb 20, 2018

bors-servo commented Feb 20, 2018

bors-servo commented Feb 20, 2018

jdm commented Feb 20, 2018

bors-servo commented Feb 20, 2018

bors-servo commented Feb 20, 2018

nox commented Feb 20, 2018 •

edited by SimonSapin