Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a use of rooted_vec in Document::handle_touch_event #20101

Merged
merged 1 commit into from Feb 22, 2018
Merged

Remove a use of rooted_vec in Document::handle_touch_event #20101

merged 1 commit into from Feb 22, 2018

Conversation

@nox
Copy link
Member

nox commented Feb 21, 2018 •
edited by SimonSapin

This change is Reviewable
@nox
Remove a use of rooted_vec in Document::handle_touch_event
Loading status checks…
3d46f67
@highfive
Copy link

highfive commented Feb 21, 2018

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented Feb 21, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@asajeffrey
Copy link
Member

asajeffrey commented Feb 21, 2018

I'm sort of torn about this change, in that it removes a use of rooted_vec, which is good, but it reduces the readability of the code, at least for me. I could follow the flow of the original, but I find the edited version difficult, in particular the nested let block. That said, it does get rid of a rooted_vec, so if you want to go for it you get an r=me.
@nox
Copy link
Member Author

nox commented Feb 21, 2018

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Feb 21, 2018

📌 Commit 3d46f67 has been approved by asajeffrey
@highfive highfive assigned asajeffrey and unassigned jdm Feb 21, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Feb 21, 2018

⌛ Testing commit 3d46f67 with merge 50c3b32...
bors-servo added a commit that referenced this pull request Feb 21, 2018
@bors-servo
Auto merge of #20101 - servo:rm-rootedvec, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
50c3b32 
Remove a use of rooted_vec in Document::handle_touch_event

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20101)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 21, 2018

💔 Test failed - mac-rel-wpt2
@nox
Copy link
Member Author

nox commented Feb 22, 2018

@bors-servo retry #JustInfraThings
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2018

⌛ Testing commit 3d46f67 with merge 9e1479b...
bors-servo added a commit that referenced this pull request Feb 22, 2018
@bors-servo
Auto merge of #20101 - servo:rm-rootedvec, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9e1479b 
Remove a use of rooted_vec in Document::handle_touch_event

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20101)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: asajeffrey
Pushing 9e1479b to master...
@bors-servo bors-servo merged commit 3d46f67 into master Feb 22, 2018
4 of 5 checks passed
4 of 5 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Feb 22, 2018
Closed
@SimonSapin SimonSapin deleted the rm-rootedvec branch Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @asajeffrey @bors-servo @jdm
You can’t perform that action at this time.