Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRequest restyle display changed from none for animations #20102
Merged
Conversation
added 4 commits
Feb 21, 2018
…none' to other
Unlike CSS animations/transitions, script animations keep alive on display:none elements, so once the display property was changed to others in normal styling, we need to do styling for the script animations in the second animation traversal. Otherwise, the styling for the script animations will be deferred to the next frame.
…y is changed from 'none' in the case the element has script animations
highfive
commented
Feb 21, 2018
|
Heads up! This PR modifies the following files:
|
highfive
commented
Feb 21, 2018
|
|
|
@bors-servo r=emilio,birtles |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 21, 2018
…none, r=emilio,birtles Request restyle display changed from none for animations <!-- Please describe your changes on the following line: --> https://bugzilla.mozilla.org/show_bug.cgi?id=1439269 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20102) <!-- Reviewable:end -->
|
|
|
@bors-servo retry #13583 |
bors-servo
added a commit
that referenced
this pull request
Feb 22, 2018
…none, r=emilio,birtles Request restyle display changed from none for animations <!-- Please describe your changes on the following line: --> https://bugzilla.mozilla.org/show_bug.cgi?id=1439269 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20102) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
hiikezoe commentedFeb 21, 2018
•
edited by SimonSapin
https://bugzilla.mozilla.org/show_bug.cgi?id=1439269
This change is