Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd font cache debugging to isolate cause of IPC failures in CI. #20106
Conversation
highfive
commented
Feb 22, 2018
|
|
| assert!(font_thread_has_closed, "Failed to receive a response from live font cache"); | ||
| panic!("Font cache thread has already exited."); | ||
| } | ||
| let reply = reply | ||
| .expect("failed to receive response to font request"); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
emilio
Feb 22, 2018
Member
Also, none of these need to use expect I guess, since we panic! on the line above... Want to either change it for unwrap(), or file an issue to revert this PR once we figure out the failures and reference it here?
| assert!(font_thread_has_closed, "Failed to receive a response from live font cache"); | ||
| panic!("Font cache thread has already exited."); | ||
| } | ||
| let reply = reply |
This comment has been minimized.
This comment has been minimized.
| assert!(font_thread_has_closed, "Failed to receive a response from live font cache"); | ||
| panic!("Font cache thread has already exited."); | ||
| } | ||
| let instance_key = instance_key |
This comment has been minimized.
This comment has been minimized.
jdm
force-pushed the
jdm:font-thread-shutdown-debug
branch
2 times, most recently
from
5810cb5
to
192b64c
|
@bors-servo r=emilio |
|
|
|
@bors-servo p=1 |
|
|
|
|
|
@bors-servo r=emilio |
|
|
Add font cache debugging to isolate cause of IPC failures in CI. This should help us better understand the actual underlying cause of frequent CI failures like #13509. In particular, we will be able to state with confidence whether an IPC message is being dropped while the font cache thread is still alive, or whether the dropped sender was in a message that was in the queue after the font cache thread was shutdown. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20106) <!-- Reviewable:end -->
|
|
jdm commentedFeb 22, 2018
•
edited by SimonSapin
This should help us better understand the actual underlying cause of frequent CI failures like #13509. In particular, we will be able to state with confidence whether an IPC message is being dropped while the font cache thread is still alive, or whether the dropped sender was in a message that was in the queue after the font cache thread was shutdown.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is