New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dont make a network request when the media attribute of a link element is modified #20115
Merged
bors-servo
merged 1 commit into
servo:master
from
janvi-palan:NoNetworkConnForHtmlListMedia
Feb 25, 2018
+0
−7
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
Loading status checks…
removed the media match case from the attribute_mutated fn
- Loading branch information
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
My concern about this patch was that, I mean... we definitely need to do something when the
mediaattribute of the link changes. At least evaluating media queries again and updating the associated stylesheet's media list.It seems we don't do that at all now... It also means that the
mutation.is_removal()bit is wrong in the condition above this.Anyway, this can be a followup, given it's severely broken anyway looks like.
r=me