Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont make a network request when the media attribute of a link element is modified #20115

Merged
merged 1 commit into from Feb 25, 2018
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

removed the media match case from the attribute_mutated fn

  • Loading branch information
janvipalan
janvipalan committed Feb 24, 2018
commit cef24def1af15ffe505021d38ee6157073ceeecd
@@ -194,13 +194,6 @@ impl VirtualMethods for HTMLLinkElement {
}
}
},
&local_name!("media") => {
if string_is_stylesheet(&rel) {
if let Some(href) = self.upcast::<Element>().get_attribute(&ns!(), &local_name!("href")) {
self.handle_stylesheet_url(&href.value());

This comment has been minimized.

Copy link
@emilio

emilio Feb 25, 2018

Member

My concern about this patch was that, I mean... we definitely need to do something when the media attribute of the link changes. At least evaluating media queries again and updating the associated stylesheet's media list.

It seems we don't do that at all now... It also means that the mutation.is_removal() bit is wrong in the condition above this.

Anyway, this can be a followup, given it's severely broken anyway looks like.

r=me

}
}
},
_ => {},
}
}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.