Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: remove unused AsciiExt imports. #20194

Merged
merged 1 commit into from Mar 4, 2018

Conversation

Projects
None yet
5 participants
@emilio
Copy link
Member

commented Mar 4, 2018

eq_ignore_ascii_case is not in AsciiExt since rustc 1.23.


This change is Reviewable

style: remove unused AsciiExt imports.
eq_ignore_ascii_case is not in AsciiExt since rustc 1.23.
@highfive

This comment has been minimized.

Copy link

commented Mar 4, 2018

Heads up! This PR modifies the following files:

  • @bholley: components/style/values/specified/time.rs, components/style/values/specified/color.rs, components/style/stylesheets/viewport_rule.rs, components/style/gecko_string_cache/mod.rs, components/style/gecko/generated/pseudo_element_definition.rs and 16 more
  • @canaltinova: components/style/values/specified/time.rs, components/style/values/specified/color.rs, components/style/stylesheets/viewport_rule.rs, components/style/gecko_string_cache/mod.rs, components/style/gecko/generated/pseudo_element_definition.rs and 16 more
@highfive

This comment has been minimized.

Copy link

commented Mar 4, 2018

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@nox

This comment has been minimized.

Copy link
Member

commented Mar 4, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2018

📌 Commit 39a3d93 has been approved by nox

@highfive highfive assigned nox and unassigned pcwalton Mar 4, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2018

⌛️ Testing commit 39a3d93 with merge fbeb5a8...

bors-servo added a commit that referenced this pull request Mar 4, 2018

Auto merge of #20194 - emilio:ascii-ext-stuff, r=nox
style: remove unused AsciiExt imports.

eq_ignore_ascii_case is not in AsciiExt since rustc 1.23.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20194)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2018

@bors-servo bors-servo merged commit 39a3d93 into servo:master Mar 4, 2018

3 of 4 checks passed

Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.