Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't clean the cargo cache on Windows. #20233
Closed
Conversation
highfive
commented
Mar 7, 2018
|
Heads up! This PR modifies the following files:
|
|
@bors-servo r+ p=100 |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 8, 2018
Don't clean the cargo cache on Windows. I previously added the CARGO_HOME for Windows builders because I thought there might be a permissions problem with the default location that was causing the errors when cloning repositories. I suspect that cleaning the cache is to blame for those somehow, since as far as I recall the problems started after #19713. Let's take it out and see if they go away! <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20233) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 8, 2018
Don't clean the cargo cache on Windows. I previously added the CARGO_HOME for Windows builders because I thought there might be a permissions problem with the default location that was causing the errors when cloning repositories. I suspect that cleaning the cache is to blame for those somehow, since as far as I recall the problems started after #19713. Let's take it out and see if they go away! <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20233) <!-- Reviewable:end -->
|
|
|
I think #20244 is what we need here instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedMar 7, 2018
•
edited by SimonSapin
I previously added the CARGO_HOME for Windows builders because I thought there might be a permissions problem with the default location that was causing the errors when cloning repositories. I suspect that cleaning the cache is to blame for those somehow, since as far as I recall the problems started after #19713. Let's take it out and see if they go away!
This change is