Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce #[css(skip_if)] #20236

Merged
merged 7 commits into from Mar 8, 2018
Merged

Introduce #[css(skip_if)] #20236

merged 7 commits into from Mar 8, 2018
+50 −68

Conversation

@emilio
Copy link
Member

emilio commented Mar 8, 2018 •
edited by SimonSapin

This is most of #20224 but without the actual counter() fix since it's waiting on a WPT update.

This change is Reviewable
emilio added 7 commits Mar 7, 2018
@emilio
style: Remove outdated TODO.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
989e1c2
@emilio
style: Remove useless String::to_string call.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
ada45f4
@emilio
style: Introduce css(skip_if) to conditionally skip serialization of …
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
6da1b2f 
…a field.
@emilio
style: reindent list-style-type.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
1f4b355
@emilio
style: Switch css(skip_if) to use a Path for consistency.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
bf08c65
@emilio
style: Document #[css(skip_if)]
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
9512508
@emilio
style: Derive ToCss for TimingFunction.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
0d7dae1
@highfive
Copy link

highfive commented Mar 8, 2018

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/list.mako.rs, components/style/values/generics/transform.rs
  • @canaltinova: components/style/properties/longhand/list.mako.rs, components/style/values/generics/transform.rs
@highfive
Copy link

highfive commented Mar 8, 2018

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Mar 8, 2018

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2018

📌 Commit 0d7dae1 has been approved by nox
@highfive highfive assigned nox and unassigned metajack Mar 8, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2018

⌛ Testing commit 0d7dae1 with merge 853609d...
bors-servo added a commit that referenced this pull request Mar 8, 2018
@bors-servo
Auto merge of #20236 - emilio:to-css-skip-if, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
853609d 
Introduce #[css(skip_if)]

This is most of #20224 but without the actual counter() fix since it's waiting on a WPT update.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2018

💔 Test failed - windows-msvc-dev
@emilio
Copy link
Member Author

emilio commented Mar 8, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt3, mac-rel-wpt4 are reusable. Rebuilding only mac-rel-css1, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2018

💔 Test failed - windows-msvc-dev
@emilio
Copy link
Member Author

emilio commented Mar 8, 2018

@bors-servo retry

  • Git failure in the MSVC builder, again...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt3, mac-rel-wpt4 are reusable. Rebuilding only mac-rel-css1, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2018

💔 Test failed - windows-msvc-dev
@emilio
Copy link
Member Author

emilio commented Mar 8, 2018

@bors-servo retry ;_;
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4 are reusable. Rebuilding only windows-msvc-dev...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2018

💔 Test failed - windows-msvc-dev
@emilio
Copy link
Member Author

emilio commented Mar 8, 2018

@bors-servo retry

  • FFUUU
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4 are reusable. Rebuilding only windows-msvc-dev...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2018

💔 Test failed - windows-msvc-dev
@emilio
Copy link
Member Author

emilio commented Mar 8, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4 are reusable. Rebuilding only windows-msvc-dev...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2018

💔 Test failed - windows-msvc-dev
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4 are reusable. Rebuilding only windows-msvc-dev...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2018

💔 Test failed - windows-msvc-dev
@jdm
Copy link
Member

jdm commented Mar 8, 2018

@bors-servo retry
@emilio emilio mentioned this pull request Mar 8, 2018
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2018

⌛ Testing commit 0d7dae1 with merge 8133f78...
bors-servo added a commit that referenced this pull request Mar 8, 2018
@bors-servo
Auto merge of #20236 - emilio:to-css-skip-if, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8133f78 
Introduce #[css(skip_if)]

This is most of #20224 but without the actual counter() fix since it's waiting on a WPT update.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20236)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing 8133f78 to master...
@bors-servo bors-servo merged commit 0d7dae1 into servo:master Mar 8, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Mar 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@emilio @highfive @bors-servo @jdm @metajack @nox
You can’t perform that action at this time.