Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnsure readonly files can be removed on Windows. #20244
Merged
Conversation
highfive
commented
Mar 8, 2018
|
Heads up! This PR modifies the following files:
|
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Mar 8, 2018
Ensure readonly files can be removed on Windows. This is based off of https://bugs.python.org/issue19643. At worst, it makes our deletion function more robust and doesn't help with the ongoing windows CI problems. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20244) <!-- Reviewable:end -->
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Mar 8, 2018
Ensure readonly files can be removed on Windows. This is based off of https://bugs.python.org/issue19643. At worst, it makes our deletion function more robust and doesn't help with the ongoing windows CI problems. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20244) <!-- Reviewable:end -->
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Mar 8, 2018
Ensure readonly files can be removed on Windows. This is based off of https://bugs.python.org/issue19643. At worst, it makes our deletion function more robust and doesn't help with the ongoing windows CI problems. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20244) <!-- Reviewable:end -->
|
Hey, it actually made clear-cargo-cache work properly on Windows! |
|
r=me with the "missing import" commit squashed into the commit that uses that import. |
|
|
|
@bors-servo r=SimonSapin |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 8, 2018
Ensure readonly files can be removed on Windows. This is based off of https://bugs.python.org/issue19643. At worst, it makes our deletion function more robust and doesn't help with the ongoing windows CI problems. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20244) <!-- Reviewable:end -->
|
|
|
@bors-servo r=SimonSapin |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 8, 2018
Ensure readonly files can be removed on Windows. This is based off of https://bugs.python.org/issue19643. At worst, it makes our deletion function more robust and doesn't help with the ongoing windows CI problems. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20244) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedMar 8, 2018
•
edited by SimonSapin
This is based off of https://bugs.python.org/issue19643. At worst, it makes our deletion function more robust and doesn't help with the ongoing windows CI problems.
This change is