Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDisable logging in bindgen to reduce code size #20245
Merged
Conversation
highfive
commented
Mar 8, 2018
|
Heads up! This PR modifies the following files:
|
highfive
commented
Mar 8, 2018
|
|
|
@bors-servo r+ |
|
|
This disables bindgen's `logging` feature, which builds `env_logger` with default features, including regex support. Disabling it allows Gecko to build `env_logger` without the `regex` crate, reducing code size. Part of https://bugzilla.mozilla.org/show_bug.cgi?id=1444097
|
@bors-servo r=emilio Missed a corresponding change in the "stylo_tests" crate. |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 8, 2018
Disable logging in bindgen to reduce code size This disables bindgen's `logging` feature, which builds `env_logger` with default features, including regex support. Disabling it allows Gecko to build `env_logger` without the `regex` crate, reducing code size. Part of https://bugzilla.mozilla.org/show_bug.cgi?id=1444097 --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they only change unused build config <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20245) <!-- Reviewable:end -->
|
|
Merged
This was referenced Mar 8, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedMar 8, 2018
•
edited by SimonSapin
This disables bindgen's
loggingfeature, which buildsenv_loggerwith default features, including regex support. Disabling it allows
Gecko to build
env_loggerwithout theregexcrate, reducing codesize.
Part of https://bugzilla.mozilla.org/show_bug.cgi?id=1444097
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is