Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart memory reports over time #20251

Merged
merged 1 commit into from Mar 9, 2018

Conversation

Projects
None yet
4 participants
@jdm
Copy link
Member

commented Mar 8, 2018

This is a tool that can take the output of Servo when run with -m N and generate an HTML file that charts the behaviour of the various labels over time.

Run with ./mach run http://url >/tmp/log; python etc/memory_reports_over_time.py /tmp/log.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Mar 8, 2018

Heads up! This PR modifies the following files:

@jdm

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2018

The result looks like:
screen shot 2018-03-08 at 5 05 14 pm

@asajeffrey

This comment has been minimized.

Copy link
Member

commented Mar 9, 2018

Is it worth doing something like the test-perf dashboards (upload data to S3, report in GDS etc)?

If this is the direction we want to go in, then LGTM. Squash and merge!

@jdm

This comment has been minimized.

Copy link
Member Author

commented Mar 9, 2018

I don't see a reason to do the whole GDS dance. I imagine this being useful for local testing, and it's easy to share the log file to allow others to run the command locally.

@jdm jdm force-pushed the jdm:memchart branch from 40029cb to dd1b43b Mar 9, 2018

@jdm

This comment has been minimized.

Copy link
Member Author

commented Mar 9, 2018

@bors-servo r=ajeffrey

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2018

📌 Commit dd1b43b has been approved by ajeffrey

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2018

⌛️ Testing commit dd1b43b with merge 324e22d...

bors-servo added a commit that referenced this pull request Mar 9, 2018

Auto merge of #20251 - jdm:memchart, r=ajeffrey
Chart memory reports over time

This is a tool that can take the output of Servo when run with `-m N` and generate an HTML file that charts the behaviour of the various labels over time.

Run with `./mach run http://url >/tmp/log; python etc/memory_reports_over_time.py /tmp/log`.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20251)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2018

@bors-servo bors-servo merged commit dd1b43b into servo:master Mar 9, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.