Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libloading to 0.5 #20288

Merged
merged 1 commit into from Mar 13, 2018
Merged

Update libloading to 0.5 #20288

merged 1 commit into from Mar 13, 2018

Conversation

@Eijebong
Copy link
Member

Eijebong commented Mar 13, 2018 •
edited by SimonSapin

This change is Reviewable
@Eijebong
Update libloading to 0.5
Loading status checks…
b598c14
@highfive
Copy link

highfive commented Mar 13, 2018

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented Mar 13, 2018

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member

emilio commented Mar 13, 2018

@bors-servo r+

Thanks as always! <3
@bors-servo
Copy link
Contributor

bors-servo commented Mar 13, 2018

📌 Commit b598c14 has been approved by emilio
@highfive highfive assigned emilio and unassigned asajeffrey Mar 13, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Mar 13, 2018

⌛ Testing commit b598c14 with merge b051e9e...
bors-servo added a commit that referenced this pull request Mar 13, 2018
@bors-servo
Auto merge of #20288 - Eijebong:libloading, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b051e9e 
Update libloading to 0.5

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20288)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 13, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing b051e9e to master...
@bors-servo bors-servo merged commit b598c14 into servo:master Mar 13, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Mar 13, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Eijebong @highfive @emilio @bors-servo @asajeffrey
You can’t perform that action at this time.