Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a newer GCC on mac for mozangle builds. #20297

Closed
wants to merge 1 commit into from
Closed

Use a newer GCC on mac for mozangle builds. #20297

wants to merge 1 commit into from

Conversation

@jdm
Copy link
Member

jdm commented Mar 14, 2018 •
edited by SimonSapin

This is an attempt to address #20281 which is hitting our mac builders relatively frequently.

This change is Reviewable
@jdm
Use a newer GCC for mozangle builds.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1a1149c
@highfive
Copy link

highfive commented Mar 14, 2018

Heads up! This PR modifies the following files:
@jdm jdm changed the title Use a newer GCC for mozangle builds. Use a newer GCC on mac for mozangle builds. Mar 14, 2018
@emilio
Copy link
Member

emilio commented Mar 14, 2018

@bors-servo r+

Huh
@bors-servo
Copy link
Contributor

bors-servo commented Mar 14, 2018

📌 Commit 1a1149c has been approved by emilio
@highfive highfive assigned emilio and unassigned mbrubeck Mar 14, 2018
@jdm
Copy link
Member Author

jdm commented Mar 14, 2018

@bors-servo r- try
@jdm
Copy link
Member Author

jdm commented Mar 14, 2018

@bors-servo clean try
@jdm
Copy link
Member Author

jdm commented Mar 14, 2018

@bors-servo clean try retry
bors-servo added a commit that referenced this pull request Mar 14, 2018
@bors-servo
Auto merge of #20297 - servo:jdm-patch-2, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0bfb70a 
Use a newer GCC on mac for mozangle builds.

This is an attempt to address #20281 which is hitting our mac builders relatively frequently.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20297)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 14, 2018

⌛ Trying commit 1a1149c with merge 0bfb70a...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 14, 2018

💔 Test failed - mac-rel-wpt1
@SimonSapin
Copy link
Member

SimonSapin commented Mar 14, 2018

https://gcc.gnu.org/ml/gcc/2016-04/msg00244.html says that the default changed from C++98 to C++14 in GCC 6.1. So maybe GCC 5 wouldn’t help, if the problem is -std=gnu++11 not being passed?
@bors-servo
Copy link
Contributor

bors-servo commented Mar 15, 2018

☔ The latest upstream changes (presumably #20260) made this pull request unmergeable. Please resolve the merge conflicts.
@jdm
Copy link
Member Author

jdm commented Mar 15, 2018

Closing in favour of #20309.
@jdm jdm closed this Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
S-needs-rebase S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@jdm @highfive @emilio @bors-servo @SimonSapin @mbrubeck
You can’t perform that action at this time.