Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump servo-websocket to 0.21 #20298

Merged
merged 1 commit into from Mar 21, 2018
Merged

Bump servo-websocket to 0.21 #20298

merged 1 commit into from Mar 21, 2018

Conversation

@Eijebong
Copy link
Member

Eijebong commented Mar 14, 2018 •
edited by SimonSapin

This change is Reviewable
@highfive
Copy link

highfive commented Mar 14, 2018

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/Cargo.toml, components/net/websocket_loader.rs
@highfive
Copy link

highfive commented Mar 14, 2018

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@Eijebong
Copy link
Member Author

Eijebong commented Mar 14, 2018

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Mar 14, 2018

⌛ Trying commit 61ba03d with merge 92b8bf6...
bors-servo added a commit that referenced this pull request Mar 14, 2018
@bors-servo
Auto merge of #20298 - Eijebong:websocket, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
92b8bf6 
[WIP] Bump servo-websocket to 0.21
@bors-servo
Copy link
Contributor

bors-servo commented Mar 14, 2018

💔 Test failed - linux-rel-wpt
@Eijebong Eijebong force-pushed the Eijebong:websocket branch from 61ba03d to 328ac3e Mar 14, 2018
@Eijebong Eijebong force-pushed the Eijebong:websocket branch 3 times, most recently from 7279de1 to 734f803 Mar 14, 2018
@Eijebong
Copy link
Member Author

Eijebong commented Mar 14, 2018

@bors-servo try

Let's see if I didn't break everything :)
bors-servo added a commit that referenced this pull request Mar 14, 2018
@bors-servo
Auto merge of #20298 - Eijebong:websocket, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
483f9e4 
[WIP] Bump servo-websocket to 0.21

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20298)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 14, 2018

⌛ Trying commit 734f803 with merge 483f9e4...
@Eijebong Eijebong changed the title [WIP] Bump servo-websocket to 0.21 Bump servo-websocket to 0.21 Mar 14, 2018
@Eijebong
Eijebong reviewed Mar 14, 2018
View changes
components/net/websocket_loader.rs Outdated
let sender = Sender::new(response.writer, true);
let receiver = Receiver::new(response.reader, false);
Ok((protocol_in_use, sender, receiver))
//response.writer

This comment has been minimized.

Sign in to view
@Eijebong

Eijebong Mar 14, 2018 •
edited

Author Member

Note to me: Remove this
@bors-servo
Copy link
Contributor

bors-servo commented Mar 14, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True
@Eijebong
Update servo-websocket to 0.21
Loading status checks…
f48d092
@Eijebong Eijebong force-pushed the Eijebong:websocket branch from 734f803 to f48d092 Mar 15, 2018
@nox
Copy link
Member

nox commented Mar 21, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 21, 2018

📌 Commit f48d092 has been approved by nox
@highfive highfive assigned nox and unassigned glennw Mar 21, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Mar 21, 2018

⌛ Testing commit f48d092 with merge 5b575e3...
bors-servo added a commit that referenced this pull request Mar 21, 2018
@bors-servo
Auto merge of #20298 - Eijebong:websocket, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5b575e3 
Bump servo-websocket to 0.21

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20298)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 21, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing 5b575e3 to master...
@bors-servo bors-servo merged commit f48d092 into servo:master Mar 21, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Mar 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Eijebong @highfive @bors-servo @nox @glennw
You can’t perform that action at this time.