Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rustc 1.26.0-nightly (5508b2714 2018-03-18) #20301

Closed
wants to merge 1 commit into from
Closed

Upgrade to rustc 1.26.0-nightly (5508b2714 2018-03-18) #20301

wants to merge 1 commit into from
+1 −1

Conversation

@Eijebong
Copy link
Member

Eijebong commented Mar 15, 2018 •
edited by SimonSapin

This fixes a bug in the compiler that made the compiler not output any
colors in errors on archlinux with a 256 colors term.

This change is Reviewable
@mbrubeck
Copy link
Contributor

mbrubeck commented Mar 15, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 15, 2018

📌 Commit 44d8517 has been approved by mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Mar 15, 2018

⌛ Testing commit 44d8517 with merge ed2a181...
bors-servo added a commit that referenced this pull request Mar 15, 2018
@bors-servo
Auto merge of #20301 - Eijebong:rustup, r=mbrubeck
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ed2a181 
Rustup

This fixes a bug in the compiler that made the compiler not output any
colors in errors on archlinux with a 256 colors term.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20301)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 15, 2018

💔 Test failed - windows-msvc-dev
@SimonSapin SimonSapin changed the title Rustup Upgrade to rustc 1.26.0-nightly (521d91c6b 2018-03-14) Mar 15, 2018
@SimonSapin
Copy link
Member

SimonSapin commented Mar 15, 2018

I’m not opposed to upgrading, but does this really fix color output? rust-lang/rust#45728 is still open and https://github.com/rust-lang/rust/tree/master/src/libterm says the last commit that touched this directory was in December.
@Eijebong
Copy link
Member Author

Eijebong commented Mar 15, 2018

Yes they are :) rust-lang/rust#48588
@mbrubeck
Copy link
Contributor

mbrubeck commented Mar 15, 2018

The Windows build timed out after 90 minutes (!) on both buildbot and appveyor. Windows builds must be hitting a hang or an extremely large perf regression in the compiler.
@Eijebong
Copy link
Member Author

Eijebong commented Mar 15, 2018

Unfortunately I don't have any windows machine, so I can't check this myself
@Eijebong
Copy link
Member Author

Eijebong commented Mar 17, 2018

rust-lang/rust#49072 Might be related
@SimonSapin
Copy link
Member

SimonSapin commented Mar 18, 2018

I couldn’t reproduce this slowdown on my windows machine (this PR built from mach clean in 28 minutes), but let’s try today’s Nightly now that it has a fix for rust-lang/rust#49072?
@Eijebong Eijebong force-pushed the Eijebong:rustup branch from 44d8517 to c6d1930 Mar 18, 2018
@Eijebong Eijebong changed the title Upgrade to rustc 1.26.0-nightly (521d91c6b 2018-03-14) Upgrade to rustc 1.26.0-nightly (adf2135ad 2018-03-17) Mar 18, 2018
@Eijebong Eijebong force-pushed the Eijebong:rustup branch from c6d1930 to 3c7189e Mar 18, 2018
@Eijebong
Upgrade to rustc 1.26.0-nightly (5508b2714 2018-03-18)
Loading status checks…
296ba8a
@Eijebong Eijebong force-pushed the Eijebong:rustup branch from 3c7189e to 296ba8a Mar 19, 2018
@Eijebong Eijebong changed the title Upgrade to rustc 1.26.0-nightly (adf2135ad 2018-03-17) Upgrade to rustc 1.26.0-nightly (5508b2714 2018-03-18) Mar 19, 2018
@SimonSapin
Copy link
Member

SimonSapin commented Mar 19, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 19, 2018

📌 Commit 296ba8a has been approved by SimonSapin
@highfive highfive assigned SimonSapin and unassigned mbrubeck Mar 19, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Mar 19, 2018

⌛ Testing commit 296ba8a with merge 159539c...
bors-servo added a commit that referenced this pull request Mar 19, 2018
@bors-servo
Auto merge of #20301 - Eijebong:rustup, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
159539c 
Upgrade to rustc 1.26.0-nightly (5508b2714 2018-03-18)

This fixes a bug in the compiler that made the compiler not output any
colors in errors on archlinux with a 256 colors term.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20301)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 19, 2018

💔 Test failed - mac-rel-css1
@Eijebong
Copy link
Member Author

Eijebong commented Mar 19, 2018

That's a lot of timeouts
@SimonSapin
Copy link
Member

SimonSapin commented Mar 19, 2018

They seem to have similar output:

  │ 2018-03-19 11:42:44.116 servo[25185:3327950660] Metadata.framework [Error]: couldn't get the client port
  │ Stack trace for thread "main"
  │ stack backtrace:
  │    0:        0x11142ef7e - backtrace::backtrace::trace::h3b0511a6df1ae4a5
  │    1:        0x11142dc7c - backtrace::capture::Backtrace::new::h21529f7f40cbaa83
  │    2:        0x10ed6abde - servo::install_crash_handler::handler::h3481f04a32a26851
  │    3:     0x7fff8eba8f19 - _sigtramp
  │    4:        0x1108fc817 - blurmac::framework::cb::centralmanager::hadb9108858bf58fa
  │    5:        0x1108f980c - blurmac::adapter::BluetoothAdapter::init::h12fc899509447924
  │    6:        0x1108e1b04 - device::bluetooth::BluetoothAdapter::init::h1a035bb7d14c2cdf
  │    7:        0x1108ba2a5 - _$LT$ipc_channel..ipc..IpcSender$LT$bluetooth_traits..BluetoothRequest$GT$$u20$as$u20$bluetooth..BluetoothThreadFactory$GT$::new::hc520f3f584afd53d
  │    8:        0x10edceae4 - servo::create_constellation::h6108e2b6a6c5115e
  │    9:        0x10ed6bbe6 - servo::main::h8d22c640247e7ed1
  │   10:        0x10ed75b05 - std::rt::lang_start::_$u7b$$u7b$closure$u7d$$u7d$::h053a9ba0604d8d0e
  │   11:        0x111445497 - std::panicking::try::do_call::h6fbdff9290bdadf9 (.llvm.12444387374658511544)
  │   12:        0x111460cbe - __rust_maybe_catch_panic
  │   13:        0x111447d81 - std::rt::lang_start_internal::h3a60217bd973f81e
  └   14:        0x10ed6cecb - main
@jdm
Copy link
Member

jdm commented Mar 26, 2018

The most useful way forward would be for someone with a mac to try to reproduce the problem, or else log into a mac builder and investigate it there.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 29, 2018

☔ The latest upstream changes (presumably #20454) made this pull request unmergeable. Please resolve the merge conflicts.
@Eijebong Eijebong closed this Mar 29, 2018
@Eijebong Eijebong mentioned this pull request Mar 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
S-needs-rebase S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Eijebong @mbrubeck @bors-servo @SimonSapin @jdm @highfive
You can’t perform that action at this time.