Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uprefactor(window): reference winit where applicable #20303
Conversation
|
Looks good, thanks! There’s just a few more items that are in both glutin and winit and can be imported from the latter: … I think. I haven’t double-checked all of them, but the compiler should tell you. In general, winit deals with windows and input events while glutin adds OpenGL contexts/apis. |
|
@SimonSapin Appreciate for suggestion, I've added changes. Now other than |
|
Looks great! |
|
uh, seems build failure on CI. let me try to amend it as well. |
|
Oops I meant to r+, but yeah there are build failures that need to be fixed before this can land. I don’t understand them based on reading the diff, though… |
|
@SimonSapin I think it's my fault to not correctly move #cfg target for mac specific. I've pushed new changes and checking CI results now |
|
Oh that makes sense. I think we don’t need to wait for Travis. @bors-servo r+ |
|
|
refactor(window): reference winit where applicable <!-- Please describe your changes on the following line: --> This is nearly first changes to rustlang code and I suspect I could make possible mistakes lot, please point me anything if need to be updated.🙏 This PR intends to update codebase per #20299 , mostly followed suggestion around #20299 (comment) to update reference to use `winit` where applicable. Confirmed local build / check works correctly for updated references. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #20299 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20303) <!-- Reviewable:end -->
|
|
kwonoj commentedMar 15, 2018
•
edited by SimonSapin
This is nearly first changes to rustlang code and I suspect I could make possible mistakes lot, please point me anything if need to be updated.🙏
This PR intends to update codebase per #20299 , mostly followed suggestion around #20299 (comment) to update reference to use
winitwhere applicable. Confirmed local build / check works correctly for updated references../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is