Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't access the reflector when dropping a Promise (fixes #18651) #20305

Merged
merged 1 commit into from Mar 15, 2018
Merged

Don't access the reflector when dropping a Promise (fixes #18651) #20305

merged 1 commit into from Mar 15, 2018

Conversation

@nox
Copy link
Member

nox commented Mar 15, 2018 •
edited by SimonSapin

The reflector may be dead already.

This change is Reviewable
@highfive
Copy link

highfive commented Mar 15, 2018

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented Mar 15, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox
Don't access the reflector when dropping a Promise (fixes #18651)
Loading status checks…
50d31f7 
The reflector may be dead already.
@nox nox force-pushed the OMAE-WA-MOU-SHINDEIRU branch from aa77e44 to 50d31f7 Mar 15, 2018
@nox nox changed the title Don't access the reflector when dropping a Promise Don't access the reflector when dropping a Promise (fixes #18651) Mar 15, 2018
@jdm
Copy link
Member

jdm commented Mar 15, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 15, 2018

📌 Commit 50d31f7 has been approved by jdm
@highfive highfive assigned jdm and unassigned mbrubeck Mar 15, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Mar 15, 2018

⌛ Testing commit 50d31f7 with merge 46a8e71...
bors-servo added a commit that referenced this pull request Mar 15, 2018
@bors-servo
Auto merge of #20305 - servo:OMAE-WA-MOU-SHINDEIRU, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
46a8e71 
Don't access the reflector when dropping a Promise (fixes #18651)

The reflector may be dead already.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20305)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 15, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 46a8e71 to master...
@bors-servo bors-servo merged commit 50d31f7 into master Mar 15, 2018
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Taskcluster (pull_request) TaskGroup: failure
Details
Tidelift Dependencies checked
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the OMAE-WA-MOU-SHINDEIRU branch May 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @jdm @bors-servo @mbrubeck
You can’t perform that action at this time.