Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement WebGL getUniform API #20330
Closed
Conversation
highfive
commented
Mar 18, 2018
|
Heads up! This PR modifies the following files:
|
highfive
commented
Mar 18, 2018
|
|
|
Don't merge this yet. This is work in progress and we need to wait for servo/gleam#147 to land first. |
|
|
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Mar 20, 2018
[WIP] Implement WebGL getUniform API <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20330) <!-- Reviewable:end -->
|
|
|
|
|
@bors-servo try |
|
@gootorov: |
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Mar 21, 2018
[WIP] Implement WebGL getUniform API <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20330) <!-- Reviewable:end -->
|
|
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Jun 20, 2018
Implement WebGL getUniform API <!-- Please describe your changes on the following line: --> Reference: [WebGL 1](https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20330) <!-- Reviewable:end -->
|
@bors-servo r+ @jdm i think it still looks good |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 20, 2018
Implement WebGL getUniform API <!-- Please describe your changes on the following line: --> Reference: [WebGL 1](https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20330) <!-- Reviewable:end -->
|
|
|
Sorry for stalling this. I had completed my exams and then I was away from the computer for quite a while. Let me know if there's anything I can assist with. |
|
Looks like the previous failure was some infrastructure error. @bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Jun 30, 2018
Implement WebGL getUniform API <!-- Please describe your changes on the following line: --> Reference: [WebGL 1](https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20330) <!-- Reviewable:end -->
|
|
|
|
|
|
|
Superseded by the changes in #21202. Sorry there were so many issues here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gootorov commentedMar 18, 2018
•
edited
Reference: WebGL 1
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is