Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Remove unsound Atom From implementations. #20339

Merged
merged 1 commit into from Mar 19, 2018
Merged

style: Remove unsound Atom From implementations. #20339

merged 1 commit into from Mar 19, 2018

Conversation

@emilio
Copy link
Member

emilio commented Mar 19, 2018 •
edited by SimonSapin

Fixes #20158

This change is Reviewable
@emilio
style: Remove unsound Atom From implementations.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
55e2cd5 
Fixes #20158
@highfive
Copy link

highfive commented Mar 19, 2018

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs, ports/geckolib/glue.rs, components/style/gecko_string_cache/mod.rs, components/style/gecko/media_queries.rs, components/style/gecko/conversions.rs and 2 more
  • @canaltinova: components/style/properties/gecko.mako.rs, components/style/gecko_string_cache/mod.rs, components/style/gecko/media_queries.rs, components/style/gecko/conversions.rs, components/style/gecko/values.rs and 1 more
@highfive
Copy link

highfive commented Mar 19, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member

nox commented Mar 19, 2018

Nice.

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 19, 2018

📌 Commit 55e2cd5 has been approved by nox
@highfive highfive assigned nox and unassigned mbrubeck Mar 19, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Mar 19, 2018

⌛ Testing commit 55e2cd5 with merge b47224d...
bors-servo added a commit that referenced this pull request Mar 19, 2018
@bors-servo
Auto merge of #20339 - emilio:atom-from-dead-beef, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b47224d 
style: Remove unsound Atom From implementations.

Fixes #20158

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20339)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 19, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing b47224d to master...
@bors-servo bors-servo merged commit 55e2cd5 into servo:master Mar 19, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@emilio @highfive @nox @bors-servo @mbrubeck
You can’t perform that action at this time.