Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mouse click #20374

Merged
merged 1 commit into from Mar 21, 2018
Merged

Fix mouse click #20374

merged 1 commit into from Mar 21, 2018

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Mar 21, 2018

PR #20071 broke mouse click on hidpi screens.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@glennw
glennw approved these changes Mar 21, 2018
@glennw
Copy link
Member

glennw commented Mar 21, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Mar 21, 2018

📌 Commit c5a0b3e has been approved by glennw

@bors-servo
Copy link
Contributor

bors-servo commented Mar 21, 2018

Testing commit c5a0b3e with merge 1594d0b...

bors-servo added a commit that referenced this pull request Mar 21, 2018
Fix mouse click

<!-- Please describe your changes on the following line: -->

PR #20071 broke mouse click on hidpi screens.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20374)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 21, 2018

@bors-servo bors-servo mentioned this pull request Mar 21, 2018
2 of 5 tasks complete
@bors-servo bors-servo merged commit c5a0b3e into servo:master Mar 21, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.