Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall down the WebGL rabbit hole and fix some bugs there #20375

Merged
merged 6 commits into from Mar 22, 2018
Merged

Fall down the WebGL rabbit hole and fix some bugs there #20375

merged 6 commits into from Mar 22, 2018

Conversation

@nox
Copy link
Member

nox commented Mar 21, 2018 •
edited by SimonSapin

This change is Reviewable
@highfive
Copy link

highfive commented Mar 21, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webglrenderingcontext.rs
  • @fitzgen: components/script/dom/webglrenderingcontext.rs
  • @KiChjang: components/script/dom/webglrenderingcontext.rs
@emilio
Copy link
Member

emilio commented Mar 21, 2018

r=me, thanks!
@nox nox force-pushed the webgl branch from e924fc3 to e158325 Mar 21, 2018
@nox
Copy link
Member Author

nox commented Mar 21, 2018

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Mar 21, 2018

📌 Commit e158325 has been approved by emilio
@highfive highfive assigned emilio and unassigned mbrubeck Mar 21, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Mar 21, 2018

⌛ Testing commit e158325 with merge 07936b4...
bors-servo added a commit that referenced this pull request Mar 21, 2018
@bors-servo
Auto merge of #20375 - servo:webgl, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
07936b4 
Fix a couple of WebGL sanity checks

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20375)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 21, 2018

💔 Test failed - linux-rel-wpt
@nox
Copy link
Member Author

nox commented Mar 21, 2018

@emilio I don't know enough about WebGL to know whether I did something wrong.
@emilio
Copy link
Member

emilio commented Mar 21, 2018

Looks like at least the "value is not an object" exception is worth checking, since that's thrown from WebIDL IIRC.
@nox nox force-pushed the webgl branch from e158325 to a5e807a Mar 22, 2018
@nox
Copy link
Member Author

nox commented Mar 22, 2018

Found out the issue: we didn't implement gl.getParameter(gl.CURRENT_PROGRAM).
@emilio
Copy link
Member

emilio commented Mar 22, 2018

r=me, but please revert the change to the webgl2 conformance test, or submit it upstream to Khronos
@nox nox force-pushed the webgl branch from a5e807a to a4d48fa Mar 22, 2018
@nox
Copy link
Member Author

nox commented Mar 22, 2018

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Mar 22, 2018

📌 Commit a4d48fa has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Mar 22, 2018

⌛ Testing commit a4d48fa with merge 6e9a039...
bors-servo added a commit that referenced this pull request Mar 22, 2018
@bors-servo
Auto merge of #20375 - servo:webgl, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6e9a039 
Fix a couple of WebGL sanity checks

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20375)
<!-- Reviewable:end -->
@nox nox changed the title Fix a couple of WebGL sanity checks Fall down the WebGL rabbit hole and fix some bugs there Mar 22, 2018
@emilio
emilio approved these changes Mar 22, 2018
View changes
@nox nox force-pushed the webgl branch from 1692551 to 4c75640 Mar 22, 2018
@nox
Copy link
Member Author

nox commented Mar 22, 2018

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Mar 22, 2018

📌 Commit 4c75640 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Mar 22, 2018

☔ The latest upstream changes (presumably #20317) made this pull request unmergeable. Please resolve the merge conflicts.
nox added 6 commits Mar 20, 2018
@nox
Fix an off-by-one error with limits.max_vertex_attribs
2a9c2bc
@nox
Implement a missing INVALID_OPERATION check in DrawArrays
3229c62
@nox
Make some WebGL parameters non-optional (fixes #8753)
f532e79 
Those parameters aren't optional in the current spec.

The test element-array-buffer-delete-recreate.html now fails because we don't
actually implement gl.getParameter(gl.CURRENT_PROGRAM).
@nox
Implement gl.getParameter(gl.CURRENT_PROGRAM)
cb6fa6e
@nox
Implement gl.getParameter(gl.VIEWPORT)
e34b19c
@nox
Don't disable canvas3d tests involving CSS transforms (fixes #8766)
Loading status checks…
c033b48 
Those don't seem to be intermittent anymore, and it's better to let
the intermittent tracker do its job anyway.
@nox nox force-pushed the webgl branch from 4c75640 to c033b48 Mar 22, 2018
@nox
Copy link
Member Author

nox commented Mar 22, 2018

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Mar 22, 2018

📌 Commit c033b48 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Mar 22, 2018

⌛ Testing commit c033b48 with merge c20d0c0...
bors-servo added a commit that referenced this pull request Mar 22, 2018
@bors-servo
Auto merge of #20375 - servo:webgl, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c20d0c0 
Fall down the WebGL rabbit hole and fix some bugs there

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20375)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 22, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing c20d0c0 to master...
@bors-servo bors-servo merged commit c033b48 into master Mar 22, 2018
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Taskcluster (pull_request) TaskGroup: failure
Details
Tidelift Dependencies checked
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @highfive @emilio @bors-servo @CYBAI @mbrubeck
You can’t perform that action at this time.