Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't OOM when laying out basic web pages on Android #20390
Merged
Conversation
highfive
commented
Mar 22, 2018
|
Heads up! This PR modifies the following files:
|
highfive
commented
Mar 22, 2018
|
|
|
r? @mbrubeck |
|
r=me if you want, with an issue filed and referenced from there. |
components/layout/inline.rs
Outdated
| self.last_known_line_breaking_opportunity = None; | ||
| mem::replace(&mut self.pending_line, | ||
| Line::new(self.floats.writing_mode, &self.minimum_metrics)) | ||
| self.pending_line = Line::new(self.floats.writing_mode, &self.minimum_metrics); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r=emilio |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 22, 2018
Don't OOM when laying out basic web pages on Android This is a workaround for the symptom described in #20149 (comment) which looks like either a standard library or compiler bug. My release android build can load all sorts of web pages as expected with this change. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20390) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedMar 22, 2018
•
edited by SimonSapin
This is a workaround for the symptom described in #20149 (comment) which looks like either a standard library or compiler bug. My release android build can load all sorts of web pages as expected with this change.
This change is