Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement OES_element_index_uint (fixes #20384) #20397
Merged
Conversation
highfive
commented
Mar 23, 2018
|
Heads up! This PR modifies the following files:
|
|
Looks reasonable. Let me know if you want me to take a closer look at the spec. |
| } | ||
|
|
||
| fn is_supported(ext: &WebGLExtensions) -> bool { | ||
| ext.supports_gl_extension("GL_OES_element_index_uint") |
This comment has been minimized.
This comment has been minimized.
emilio
Mar 23, 2018
Member
I wonder if this should just default to ext.supports_gl_extension(Self::name())
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r=emilio |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 23, 2018
Implement OES_element_index_uint (fixes #20384) <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20397) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nox commentedMar 23, 2018
•
edited by SimonSapin
This change is