Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate fontconfig submodule for https://github.com/mozilla-servo/fontconfig/pull/1 #2040
Conversation
This of course depends on servo/fontconfig#1 being merged.
hoppipolla-critic-bot
commented
Apr 4, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/1172 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
This comment has been minimized.
This comment has been minimized.
jdm
commented on a24e52a
Apr 5, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
@bors: retry |
This comment has been minimized.
This comment has been minimized.
metajack
replied
Apr 7, 2014
|
@bors: retry |
This comment has been minimized.
This comment has been minimized.
jdm
replied
Apr 8, 2014
|
@bors: retry |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging SimonSapin/servo/fontconfig-compile = a24e52a into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
some tests failed: |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging SimonSapin/servo/fontconfig-compile = a24e52a into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 384183a |
This of course depends on servo/fontconfig#1 being merged.
Awkward. |
|
Not sure what happened here. servo/fontconfig#1 was merged hours before you r+’d this, and a fresh clone of https://github.com/mozilla-servo/fontconfig.git definitely contains servo/fontconfig@0450af3 for me. |
This of course depends on servo/fontconfig#1 being merged.
|
Ah, this is the relevant part: |
|
I can not reproduce this locally. I believe the build slave has uncommitted local changes to its |
This of course depends on servo/fontconfig#1 being merged.
This of course depends on servo/fontconfig#1 being merged.
a24e52a
into
servo:master
SimonSapin commentedApr 4, 2014
This of course depends on servo/fontconfig#1 being merged.