Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GamepadButtonList::sync_from_vr should use more iterators #20392 #20404

Merged
merged 1 commit into from Mar 24, 2018
Merged

GamepadButtonList::sync_from_vr should use more iterators #20392 #20404

merged 1 commit into from Mar 24, 2018

Conversation

@MaximilianDauner
Copy link
Contributor

MaximilianDauner commented Mar 23, 2018 •
edited by jdm

Used the zip function instead of iterating over both vectors with an indexing variable and using unwrap.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #20392(github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because it says in the issue description no need for tests

This change is Reviewable
@MaximilianDauner
Used the zip function to iterate over both vectors simultaneously ins…
Loading status checks…
b42e54f 
…tead of an

index variable and unwrapping the result.
@highfive
Copy link

highfive commented Mar 23, 2018

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.
@highfive
Copy link

highfive commented Mar 23, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/gamepadbuttonlist.rs
  • @fitzgen: components/script/dom/gamepadbuttonlist.rs
  • @KiChjang: components/script/dom/gamepadbuttonlist.rs
@highfive
Copy link

highfive commented Mar 23, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Mar 23, 2018

@bors-servo r+
Thanks for cleaning this up!
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2018

📌 Commit b42e54f has been approved by jdm
@highfive highfive assigned jdm and unassigned Manishearth Mar 23, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2018

⌛ Testing commit b42e54f with merge 466faeb...
bors-servo added a commit that referenced this pull request Mar 23, 2018
@bors-servo
Auto merge of #20404 - MaximilianDauner:issue_20392, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
466faeb 
GamepadButtonList::sync_from_vr should use more iterators #20392

<!-- Please describe your changes on the following line: -->
Used the zip function instead of iterating over both vectors with an indexing variable and using unwrap.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20392(github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because it says in the issue description no need for tests
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20404)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 23, 2018

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Mar 24, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2018

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Mar 24, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2018

⌛ Testing commit b42e54f with merge 5a432ea...
bors-servo added a commit that referenced this pull request Mar 24, 2018
@bors-servo
Auto merge of #20404 - MaximilianDauner:issue_20392, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5a432ea 
GamepadButtonList::sync_from_vr should use more iterators #20392

<!-- Please describe your changes on the following line: -->
Used the zip function instead of iterating over both vectors with an indexing variable and using unwrap.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20392(github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because it says in the issue description no need for tests
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20404)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 5a432ea to master...
@bors-servo bors-servo merged commit b42e54f into servo:master Mar 24, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

GamepadButtonList::sync_from_vr should use more iterators
5 participants
@MaximilianDauner @highfive @jdm @bors-servo @Manishearth
You can’t perform that action at this time.