Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fetch): accept arraybuffer in consume_body #20406

Merged
merged 4 commits into from Mar 24, 2018
+39 −269
Merged

feat(fetch): accept arraybuffer in consume_body #20406

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c0b5eee
feat(webidl): expose arraybuffer overload in body idl
kwonoj Mar 23, 2018
168f610
feat(consume_body): implement consume_body accepts arraybuffer
kwonoj Mar 23, 2018
e6de213
refactor(consume_body): json stored in roottraceablebox
kwonoj Mar 24, 2018
80304a1
test(wpt): update fetch test metadata
kwonoj Mar 23, 2018
File filter...
Filter file types
Clear filters
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Prev
Loading status checks…

test(wpt): update fetch test metadata

  • Loading branch information
@kwonoj
kwonoj committed Mar 24, 2018
Verified
This commit was signed with a verified signature.
kwonoj OJ Kwon
GPG key ID: 2E469434030C7F09 Learn about signing commits
commit 80304a133f66ba4bda0070d29a36043d8f4b4334
29 tests/wpt/metadata/fetch/api/basic/text-utf8.html.ini
View file
Open in desktop
@@ -36,33 +36,4 @@
[UTF-16 without BOM decoded as UTF-8 with Response.text()]
expected: FAIL

[UTF-8 with BOM (Response object)]
expected: FAIL

[UTF-8 with BOM (Request object)]
expected: FAIL

[UTF-8 without BOM (Response object)]
expected: FAIL

[UTF-8 without BOM (Request object)]
expected: FAIL

[UTF-16BE with BOM decoded as UTF-8 (Response object)]
expected: FAIL

[UTF-16BE with BOM decoded as UTF-8 (Request object)]
expected: FAIL

[UTF-16LE with BOM decoded as UTF-8 (Response object)]
expected: FAIL

[UTF-16LE with BOM decoded as UTF-8 (Request object)]
expected: FAIL

[UTF-16 without BOM decoded as UTF-8 (Response object)]
expected: FAIL

[UTF-16 without BOM decoded as UTF-8 (Request object)]
expected: FAIL

6 tests/wpt/metadata/fetch/api/request/request-consume-empty.html.ini
View file
Open in desktop
@@ -6,12 +6,6 @@
[Consume request's body as formData]
expected: FAIL

[Consume empty blob request body as arrayBuffer]
expected: FAIL

[Consume empty text request body as arrayBuffer]
expected: FAIL

[Consume request's body as text]
expected: FAIL
9 tests/wpt/metadata/fetch/api/request/request-consume.html.ini
View file
Open in desktop
@@ -1,17 +1,11 @@
[request-consume.html]
type: testharness
[Consume String request's body as arrayBuffer]
expected: FAIL
[Consume String request's body as json]
expected: FAIL
[Consume String request's body as formData]
expected: FAIL

[Consume blob response's body as arrayBuffer]
expected: FAIL

[Trying to consume bad JSON text as JSON: 'undefined']
expected: FAIL

@@ -51,9 +45,6 @@
[Consume FormData request's body as FormData]
expected: FAIL

[Consume blob response's body as arrayBuffer]
expected: FAIL
[Trying to consume bad JSON text as JSON: 'undefined']
expected: FAIL

3 tests/wpt/metadata/fetch/api/request/request-idl.html.ini
View file
Open in desktop
@@ -30,6 +30,3 @@
[Request interface: new Request("") must inherit property "body" with the proper type]
expected: FAIL

[Request interface: new Request("") must inherit property "arrayBuffer()" with the proper type]
expected: FAIL

2 tests/wpt/metadata/fetch/api/request/request-structure.html.ini
View file
Open in desktop
@@ -1,5 +1,3 @@
[request-structure.html]
type: testharness
[Request has arrayBuffer method]
expected: FAIL

12 tests/wpt/metadata/fetch/api/response/response-consume.html.ini
View file
Open in desktop
@@ -24,15 +24,9 @@
[Consume fetched response's body as arrayBuffer]
expected: FAIL

[Consume response's body: from text to arrayBuffer]
expected: FAIL
[Consume response's body: from text with correct multipart type to formData]
expected: FAIL
[Consume response's body: from blob to arrayBuffer]
expected: FAIL
[Consume response's body: from blob with correct multipart type to formData]
expected: FAIL

@@ -48,9 +42,6 @@
[Consume response's body: from FormData to arrayBuffer]
expected: FAIL

[Consume response's body: from URLSearchParams to arrayBuffer]
expected: FAIL
[Consume response's body: from stream to blob]
expected: FAIL
@@ -78,9 +69,6 @@
[Consume response's body: from fetch to blob]
expected: FAIL
[Consume response's body: from fetch to arrayBuffer]
expected: FAIL
[Consume response's body: from multipart form data blob to formData]
expected: FAIL

6 tests/wpt/metadata/fetch/api/response/response-idl.html.ini
View file
Open in desktop
@@ -21,9 +21,6 @@
[Response interface: new Response() must inherit property "body" with the proper type (8)]
expected: FAIL

[Response interface: new Response() must inherit property "arrayBuffer" with the proper type (11)]
expected: FAIL

[Response interface: new Response() must inherit property "body" with the proper type (9)]
expected: FAIL

@@ -45,6 +42,3 @@
[Response interface: new Response() must inherit property "body" with the proper type]
expected: FAIL

[Response interface: new Response() must inherit property "arrayBuffer()" with the proper type]
expected: FAIL

2 tests/wpt/metadata/fetch/api/response/response-stream-disturbed-5.html.ini
View file
Open in desktop
@@ -1,5 +1,3 @@
[response-stream-disturbed-5.html]
type: testharness
[Getting a body reader after consuming as arrayBuffer]
expected: FAIL

This comment has been minimized.

Sign in to view
@KiChjang

KiChjang Mar 24, 2018

Member

Shouldn't this file be deleted altogether?

This comment has been minimized.

Sign in to view
@jdm

jdm Mar 24, 2018

Member

It will be automatically in the future.

123 tests/wpt/metadata/fetch/data-urls/base64.any.js.ini
View file
Open in desktop
@@ -1,46 +1,8 @@
[base64.any.worker.html]
[data: URL base64 handling: ""]
expected: FAIL

[data: URL base64 handling: "abcd"]
expected: FAIL

[data: URL base64 handling: " abcd"]
expected: FAIL

[data: URL base64 handling: "abcd "]
expected: FAIL

[data: URL base64 handling: "ab"]
expected: FAIL

[data: URL base64 handling: "abc"]
expected: FAIL

[data: URL base64 handling: "ab="]
expected: FAIL

[data: URL base64 handling: "ab=="]
expected: FAIL

[data: URL base64 handling: "abc="]
expected: FAIL

[data: URL base64 handling: "ab\\tcd"]
expected: FAIL

[data: URL base64 handling: "ab\\ncd"]
expected: FAIL

[data: URL base64 handling: "ab\\fcd"]
expected: FAIL

[data: URL base64 handling: "ab\\rcd"]
expected: FAIL

[data: URL base64 handling: "ab cd"]
expected: FAIL

[data: URL base64 handling: "ab\\t\\n\\f\\r cd"]
expected: FAIL

@@ -50,74 +12,12 @@
[data: URL base64 handling: "ab\\t\\n\\f\\r =\\t\\n\\f\\r =\\t\\n\\f\\r "]
expected: FAIL

[data: URL base64 handling: "/A"]
expected: FAIL

[data: URL base64 handling: "//A"]
expected: FAIL

[data: URL base64 handling: "///A"]
expected: FAIL

[data: URL base64 handling: "A/"]
expected: FAIL

[data: URL base64 handling: "AA/"]
expected: FAIL

[data: URL base64 handling: "AAA/"]
expected: FAIL

[data: URL base64 handling: "YQ"]
expected: FAIL

[data: URL base64 handling: "YR"]
expected: FAIL


[base64.any.html]
[data: URL base64 handling: ""]
expected: FAIL

[data: URL base64 handling: "abcd"]
expected: FAIL

[data: URL base64 handling: " abcd"]
expected: FAIL

[data: URL base64 handling: "abcd "]
expected: FAIL

[data: URL base64 handling: "ab"]
expected: FAIL

[data: URL base64 handling: "abc"]
expected: FAIL

[data: URL base64 handling: "ab="]
expected: FAIL

[data: URL base64 handling: "ab=="]
expected: FAIL

[data: URL base64 handling: "abc="]
expected: FAIL

[data: URL base64 handling: "ab\\tcd"]
expected: FAIL

[data: URL base64 handling: "ab\\ncd"]
expected: FAIL

[data: URL base64 handling: "ab\\fcd"]
expected: FAIL

[data: URL base64 handling: "ab\\rcd"]
expected: FAIL

[data: URL base64 handling: "ab cd"]
expected: FAIL

[data: URL base64 handling: "ab\\t\\n\\f\\r cd"]
expected: FAIL

@@ -127,27 +27,4 @@
[data: URL base64 handling: "ab\\t\\n\\f\\r =\\t\\n\\f\\r =\\t\\n\\f\\r "]
expected: FAIL

[data: URL base64 handling: "/A"]
expected: FAIL

[data: URL base64 handling: "//A"]
expected: FAIL

[data: URL base64 handling: "///A"]
expected: FAIL

[data: URL base64 handling: "A/"]
expected: FAIL

[data: URL base64 handling: "AA/"]
expected: FAIL

[data: URL base64 handling: "AAA/"]
expected: FAIL

[data: URL base64 handling: "YQ"]
expected: FAIL

[data: URL base64 handling: "YR"]
expected: FAIL

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.