Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement gl.getParameter(gl.ALIASED_POINT_SIZE_RANGE) #20414

Merged
merged 1 commit into from Mar 24, 2018
Merged

Implement gl.getParameter(gl.ALIASED_POINT_SIZE_RANGE) #20414

merged 1 commit into from Mar 24, 2018

Conversation

@nox
Copy link
Member

nox commented Mar 24, 2018 •
edited by SimonSapin

This change is Reviewable
@nox
Implement gl.getParameter(gl.ALIASED_POINT_SIZE_RANGE)
Loading status checks…
d6ebbd3
@highfive
Copy link

highfive commented Mar 24, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webglrenderingcontext.rs, components/script/Cargo.toml
  • @paulrouget: components/compositing/Cargo.toml, components/servo/Cargo.toml, ports/servo/Cargo.toml
  • @fitzgen: components/script/dom/webglrenderingcontext.rs, components/script/Cargo.toml
  • @KiChjang: components/script/dom/webglrenderingcontext.rs, components/script/Cargo.toml
@emilio
emilio approved these changes Mar 24, 2018
View changes
@nox
Copy link
Member Author

nox commented Mar 24, 2018

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2018

📌 Commit d6ebbd3 has been approved by emilio
@highfive highfive assigned emilio and unassigned glennw Mar 24, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2018

⌛ Testing commit d6ebbd3 with merge 133b02e...
bors-servo added a commit that referenced this pull request Mar 24, 2018
@bors-servo
Auto merge of #20414 - servo:webgl, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
133b02e 
Implement gl.getParameter(gl.ALIASED_POINT_SIZE_RANGE)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20414)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2018

💔 Test failed - mac-rel-css2
@nox
Copy link
Member Author

nox commented Mar 24, 2018

@bors-servo retry #20418
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2018

⌛ Testing commit d6ebbd3 with merge 782d4d4...
bors-servo added a commit that referenced this pull request Mar 24, 2018
@bors-servo
Auto merge of #20414 - servo:webgl, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
782d4d4 
Implement gl.getParameter(gl.ALIASED_POINT_SIZE_RANGE)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20414)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 782d4d4 to master...
@bors-servo bors-servo merged commit d6ebbd3 into master Mar 24, 2018
4 of 5 checks passed
4 of 5 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
Tidelift Dependencies checked
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Apr 4, 2018
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @bors-servo @emilio @glennw
You can’t perform that action at this time.