Move DL items from gfx to layout and implement corner clipping #20420

pyfisch · 2018-03-24T21:26:43Z

Implement corner clipping.
Remove PixelFormat from WebrenderImageInfo.
Use WebRender text shadow.
Remove MallocSizeOf and Deserialize for DL items.

Closes #19649, closes #19680, closes #19802

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #__ (github issue number if applicable).

There are tests for these changes OR
These changes do not require tests because _____

This change is

highfive · 2018-03-24T21:26:47Z

Heads up! This PR modifies the following files:

@emilio: components/layout/block.rs, components/layout/animation.rs, components/layout/display_list/background.rs, components/layout/display_list/items.rs, components/layout/opaque_node.rs and 10 more

pyfisch · 2018-03-24T21:27:26Z

@bors-servo try

bors-servo · 2018-03-24T21:27:30Z

⌛ Trying commit 26ace4c with merge 50b6e63...


        Auto merge of #20420 - pyfisch:corner-clipping, r=<try>

WIP Move DL items from gfx to layout Implement corner clipping. Remove PixelFormat from WebrenderImageInfo. Use WebRender text shadow. Remove MallocSizeOf and Deserialize for DL items. Closes #19649, #19680, #19802  ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20420)

bors-servo · 2018-03-24T21:37:18Z

💔 Test failed - mac-dev-unit

servo-wpt-sync · 2018-03-25T14:19:04Z

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#44.

pyfisch · 2018-03-25T15:55:06Z

http://build.servo.org/builders/linux-rel-wpt/builds/8339/steps/shell__4/logs/filtered-wpt-errorsummary.log

pyfisch · 2018-03-25T18:57:19Z

This is now ready for review.

The two failing tests are some weird bug that only occurs for elements with direction: rtl in certain conditions. It appears that the WritingMode is empty for these elements while the border_padding has direction RTL. This causes an assertion in debug mode to fail.

pyfisch · 2018-03-25T19:20:53Z

@Manishearth: You created the "build_display_list_for_background_if_applicable_with_background" method. I guess based on the name it should display the provided background instead of the element background. But in only uses the provided background for color and not for images and gradients. (It does not suffice to remove the line because the different images again access the background via style: &ComputedValues.

Manishearth · 2018-03-25T20:57:13Z

Ah, oops. It should be using the same background. You're right that that's not enough; fixing the rest is a part of the fix for #20093 (which I haven't had time to get to)

servo-wpt-sync · 2018-04-21T18:16:24Z

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#44.

pyfisch · 2018-04-21T18:17:28Z

@bors-servo try

servo-wpt-sync · 2018-04-21T18:52:30Z

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#44.

pyfisch · 2018-04-21T18:58:43Z

@bors-servo try

pyfisch · 2018-04-21T19:46:43Z

r? @emilio

This PR moves the display list items from the gfx crate to layout. They are only ever used in layout and moving them there will hopefully decrease compile when modifying these items as gfx stays untouched. This also adds corner clipping for backgrounds along with a test.

Previously this used the same code to clip the background color and the background images but I reverted it because of two failing right-to-left tests.

As you see I tried to start bors but for some reason the bot is not replying?


        Move DL items from gfx to layout

Implement corner clipping. Remove PixelFormat from WebrenderImageInfo. Use WebRender text shadow. Remove MallocSizeOf and Deserialize for DL items. Closes #19649, #19680, #19802

servo-wpt-sync · 2018-04-22T11:15:12Z

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#44.

bors-servo · 2018-04-27T19:49:20Z

💔 Test failed - mac-rel-wpt2

pyfisch · 2018-04-27T22:20:39Z

@bors-servo retry

bors-servo · 2018-04-27T22:20:46Z

⌛ Trying commit aada975 with merge 1546cfe...


        Auto merge of #20420 - pyfisch:corner-clipping, r=<try>

Move DL items from gfx to layout and implement corner clipping Implement corner clipping. Remove PixelFormat from WebrenderImageInfo. Use WebRender text shadow. Remove MallocSizeOf and Deserialize for DL items. Closes #19649, closes #19680, closes #19802  ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #__ (github issue number if applicable).  - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20420)

bors-servo · 2018-04-28T08:29:41Z

💥 Test timed out

pyfisch · 2018-04-28T08:45:33Z

@emilio, @nox I don't know what "test timed out" means. This PR didn't pass CI now so many times (for reasons probably outside my code) that I give up trying.

Can you merge the PR for me? Tell me if the code needs changes.

nox · 2018-04-28T08:54:56Z

@bors-servo retry

bors-servo · 2018-04-28T08:55:04Z

⌛ Trying commit aada975 with merge 7f1311d...


        Auto merge of #20420 - pyfisch:corner-clipping, r=<try>

Move DL items from gfx to layout and implement corner clipping Implement corner clipping. Remove PixelFormat from WebrenderImageInfo. Use WebRender text shadow. Remove MallocSizeOf and Deserialize for DL items. Closes #19649, closes #19680, closes #19802  ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #__ (github issue number if applicable).  - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20420)

bors-servo · 2018-04-28T09:22:53Z

💔 Test failed - linux-rel-wpt

CYBAI · 2018-04-28T15:30:25Z

{"status": "FAIL", "group": "default", "message": "ReferrerPolicyTestCase is not defined", "stack": "@http://web-platform.test:8000/referrer-policy/origin-when-cross-origin/http-rp/cross-origin/http-https/iframe-tag/cross-origin.no-redirect.http.html:23:7\n", "subtest": "Referrer-Policy: Referrer Policy is set to 'origin-when-cross-origin'", "test": "/referrer-policy/origin-when-cross-origin/http-rp/cross-origin/http-https/iframe-tag/cross-origin.no-redirect.http.html", "line": 179025, "action": "test_result", "expected": "PASS"}
{"status": "OK", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/referrer-policy/origin-when-cross-origin/http-rp/cross-origin/http-https/iframe-tag/cross-origin.no-redirect.http.html", "line": 179026, "action": "test_result", "expected": "TIMEOUT"}

emilio · 2018-04-29T06:09:58Z

@bors-servo r+

bors-servo · 2018-04-29T06:09:59Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: #20678

bors-servo · 2018-04-29T06:09:59Z

📌 Commit aada975 has been approved by emilio

emilio · 2018-04-29T06:10:12Z

@bors-servo retry

bors-servo · 2018-04-29T06:30:20Z

⌛ Testing commit aada975 with merge 0ff6f32...


        Auto merge of #20420 - pyfisch:corner-clipping, r=emilio

Move DL items from gfx to layout and implement corner clipping Implement corner clipping. Remove PixelFormat from WebrenderImageInfo. Use WebRender text shadow. Remove MallocSizeOf and Deserialize for DL items. Closes #19649, closes #19680, closes #19802  ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #__ (github issue number if applicable).  - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20420)

bors-servo · 2018-04-29T07:57:42Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 0ff6f32 to master...


        Move DL items from gfx to layout

Implement corner clipping. Remove PixelFormat from WebrenderImageInfo. Use WebRender text shadow. Remove MallocSizeOf and Deserialize for DL items. Closes #19649, #19680, #19802 Upstreamed from servo/servo#20420 [ci skip]


        Place item clipping_and_scrolling inside closure

A utility function assures that if the clipping and scrolling are changed for a display item the old value is later restored. Upstreamed from servo/servo#20420 [ci skip]

highfive assigned Manishearth Mar 24, 2018

highfive added the S-awaiting-review label Mar 24, 2018

highfive added the S-tests-failed label Mar 24, 2018

pyfisch force-pushed the pyfisch:corner-clipping branch from 26ace4c to fbc801f Mar 25, 2018

highfive removed the S-tests-failed label Mar 25, 2018

servo-wpt-sync mentioned this pull request Mar 25, 2018

WIP Move DL items from gfx to layout jdm/web-platform-tests#44

Closed

pyfisch mentioned this pull request Mar 25, 2018

box with direction: rtl is displayed on wrong side #20427

Open

pyfisch changed the title ~~WIP Move DL items from gfx to layout~~ Move DL items from gfx to layout Mar 25, 2018

pyfisch force-pushed the pyfisch:corner-clipping branch from fbc801f to 7fa28e3 Apr 21, 2018

pyfisch force-pushed the pyfisch:corner-clipping branch from 7fa28e3 to 04c732a Apr 21, 2018

highfive assigned emilio and unassigned Manishearth Apr 21, 2018

Move DL items from gfx to layout

Loading status checks…

c0be925

Implement corner clipping. Remove PixelFormat from WebrenderImageInfo. Use WebRender text shadow. Remove MallocSizeOf and Deserialize for DL items. Closes #19649, #19680, #19802

pyfisch force-pushed the pyfisch:corner-clipping branch from 04c732a to c0be925 Apr 22, 2018

highfive added the S-tests-failed label Apr 27, 2018

highfive added the S-tests-failed label Apr 28, 2018

highfive added S-awaiting-merge and removed S-tests-failed labels Apr 29, 2018

highfive removed the S-awaiting-merge label Apr 29, 2018

bors-servo mentioned this pull request Apr 29, 2018

Font fallback #20506

Merged

servo-wpt-sync mentioned this pull request May 1, 2018

Move DL items from gfx to layout web-platform-tests/wpt#10729

Merged

servo-wpt-sync mentioned this pull request May 1, 2018

Place item clipping_and_scrolling inside closure web-platform-tests/wpt#10733

Merged

pyfisch deleted the pyfisch:corner-clipping branch May 2, 2018

servo / servo

Move DL items from gfx to layout and implement corner clipping #20420

Move DL items from gfx to layout and implement corner clipping #20420

pyfisch commented Mar 24, 2018 •

edited by atouchet

highfive commented Mar 24, 2018

pyfisch commented Mar 24, 2018

bors-servo commented Mar 24, 2018

bors-servo commented Mar 24, 2018

servo-wpt-sync commented Mar 25, 2018

pyfisch commented Mar 25, 2018

pyfisch commented Mar 25, 2018

pyfisch commented Mar 25, 2018

Manishearth commented Mar 25, 2018

servo-wpt-sync commented Apr 21, 2018

pyfisch commented Apr 21, 2018

servo-wpt-sync commented Apr 21, 2018

pyfisch commented Apr 21, 2018

pyfisch commented Apr 21, 2018

servo-wpt-sync commented Apr 22, 2018

bors-servo commented Apr 27, 2018

pyfisch commented Apr 27, 2018

bors-servo commented Apr 27, 2018

bors-servo commented Apr 28, 2018

pyfisch commented Apr 28, 2018

nox commented Apr 28, 2018

bors-servo commented Apr 28, 2018

bors-servo commented Apr 28, 2018

CYBAI commented Apr 28, 2018

emilio commented Apr 29, 2018

bors-servo commented Apr 29, 2018

bors-servo commented Apr 29, 2018

emilio commented Apr 29, 2018

bors-servo commented Apr 29, 2018

bors-servo commented Apr 29, 2018

servo / servo

Join GitHub today

Move DL items from gfx to layout and implement corner clipping #20420

Move DL items from gfx to layout and implement corner clipping #20420

Conversation

pyfisch commented Mar 24, 2018 • edited by atouchet

highfive commented Mar 24, 2018

pyfisch commented Mar 24, 2018

bors-servo commented Mar 24, 2018

bors-servo commented Mar 24, 2018

servo-wpt-sync commented Mar 25, 2018

pyfisch commented Mar 25, 2018

pyfisch commented Mar 25, 2018

pyfisch commented Mar 25, 2018

Manishearth commented Mar 25, 2018

servo-wpt-sync commented Apr 21, 2018

pyfisch commented Apr 21, 2018

servo-wpt-sync commented Apr 21, 2018

pyfisch commented Apr 21, 2018

pyfisch commented Apr 21, 2018

servo-wpt-sync commented Apr 22, 2018

bors-servo commented Apr 27, 2018

pyfisch commented Apr 27, 2018

bors-servo commented Apr 27, 2018

bors-servo commented Apr 28, 2018

pyfisch commented Apr 28, 2018

nox commented Apr 28, 2018

bors-servo commented Apr 28, 2018

bors-servo commented Apr 28, 2018

CYBAI commented Apr 28, 2018

emilio commented Apr 29, 2018

bors-servo commented Apr 29, 2018

bors-servo commented Apr 29, 2018

emilio commented Apr 29, 2018

bors-servo commented Apr 29, 2018

bors-servo commented Apr 29, 2018

pyfisch commented Mar 24, 2018 •

edited by atouchet