Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typed array support for XMLHttpRequest's send API #20434

Merged
merged 2 commits into from Mar 29, 2018
+29 −278
Merged

Typed array support for XMLHttpRequest's send API #20434

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2009c4e
typed array support for XMLHttpRequest's send API
nupurbaghel Mar 24, 2018
3f06ccb
updated the test files due to typed array support
nupurbaghel Mar 29, 2018
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

2 components/script/dom/webidls/XMLHttpRequest.webidl
View file
Open in desktop
@@ -13,7 +13,7 @@
*/

// https://fetch.spec.whatwg.org/#bodyinit
typedef (Blob or /*BufferSource or */ FormData or DOMString or URLSearchParams) BodyInit;
typedef (Blob or BufferSource or FormData or DOMString or URLSearchParams) BodyInit;

enum XMLHttpRequestResponseType {
"",
4 components/script/dom/xmlhttprequest.rs
View file
Open in desktop
@@ -520,6 +520,8 @@ impl XMLHttpRequestMethods for XMLHttpRequest {
Some(DocumentOrBodyInit::FormData(ref formdata)) => Some(formdata.extract()),
Some(DocumentOrBodyInit::String(ref str)) => Some(str.extract()),
Some(DocumentOrBodyInit::URLSearchParams(ref urlsp)) => Some(urlsp.extract()),
Some(DocumentOrBodyInit::ArrayBuffer(ref typedarray)) => Some((typedarray.to_vec(), None)),
Some(DocumentOrBodyInit::ArrayBufferView(ref typedarray)) => Some((typedarray.to_vec(), None)),
None => None,
};

@@ -1441,6 +1443,8 @@ impl Extractable for BodyInit {
BodyInit::URLSearchParams(ref usp) => usp.extract(),
BodyInit::Blob(ref b) => b.extract(),
BodyInit::FormData(ref formdata) => formdata.extract(),
BodyInit::ArrayBuffer(ref typedarray) => ((typedarray.to_vec(), None)),
BodyInit::ArrayBufferView(ref typedarray) => ((typedarray.to_vec(), None)),
}
}
}
18 tests/wpt/metadata/fetch/api/basic/request-headers.any.js.ini
View file
Open in desktop
@@ -12,24 +12,6 @@
[Fetch with POST with URLSearchParams body]
expected: FAIL

[Fetch with POST with ArrayBuffer body]
expected: FAIL

[Fetch with POST with Uint8Array body]
expected: FAIL

[Fetch with POST with Int8Array body]
expected: FAIL

[Fetch with POST with Float32Array body]
expected: FAIL

[Fetch with POST with Float64Array body]
expected: FAIL

[Fetch with POST with DataView body]
expected: FAIL

[Fetch with POST with Blob body with mime type]
expected: FAIL

36 tests/wpt/metadata/fetch/api/basic/request-upload.any.js.ini
View file
Open in desktop
@@ -1,23 +1,5 @@
[request-upload.any.html]
type: testharness
[Fetch with POST with ArrayBuffer body]
expected: FAIL

[Fetch with POST with Uint8Array body]
expected: FAIL

[Fetch with POST with Int8Array body]
expected: FAIL

[Fetch with POST with Float32Array body]
expected: FAIL

[Fetch with POST with Float64Array body]
expected: FAIL

[Fetch with POST with DataView body]
expected: FAIL

[Fetch with POST with ReadableStream]
expected: FAIL

@@ -39,24 +21,6 @@

[request-upload.any.worker.html]
type: testharness
[Fetch with POST with ArrayBuffer body]
expected: FAIL

[Fetch with POST with Uint8Array body]
expected: FAIL

[Fetch with POST with Int8Array body]
expected: FAIL

[Fetch with POST with Float32Array body]
expected: FAIL

[Fetch with POST with Float64Array body]
expected: FAIL

[Fetch with POST with DataView body]
expected: FAIL

[Fetch with POST with ReadableStream]
expected: FAIL

24 tests/wpt/metadata/fetch/api/basic/text-utf8.html.ini
View file
Open in desktop
@@ -12,27 +12,3 @@
[UTF-8 with BOM with fetched data (UTF-16 charset)]
expected: FAIL

[UTF-8 without BOM with Request.text()]
expected: FAIL

[UTF-8 without BOM with Response.text()]
expected: FAIL

[UTF-16BE with BOM decoded as UTF-8 with Request.text()]
expected: FAIL

[UTF-16BE with BOM decoded as UTF-8 with Response.text()]
expected: FAIL

[UTF-16LE with BOM decoded as UTF-8 with Request.text()]
expected: FAIL

[UTF-16LE with BOM decoded as UTF-8 with Response.text()]
expected: FAIL

[UTF-16 without BOM decoded as UTF-8 with Request.text()]
expected: FAIL

[UTF-16 without BOM decoded as UTF-8 with Response.text()]
expected: FAIL

6 tests/wpt/metadata/fetch/api/request/request-consume-empty.html.ini
View file
Open in desktop
@@ -18,9 +18,6 @@
[Consume empty FormData request body as text]
expected: FAIL
[Consume empty ArrayBuffer request body as text]
expected: FAIL
[Consume request's body as json (error case)]
expected: FAIL

@@ -33,3 +30,6 @@
[Consume request's body as formData without correct type (error case)]
expected: FAIL
[Consume empty ArrayBuffer request body as text]
expected: FAIL
42 tests/wpt/metadata/fetch/api/request/request-consume.html.ini
View file
Open in desktop
@@ -6,66 +6,66 @@
[Consume String request's body as formData]
expected: FAIL

[Consume Int8Array request's body as text]
[Consume FormData request's body as FormData]
expected: FAIL
[Consume Int8Array request's body as blob]
[Consume ArrayBuffer request's body as blob]
expected: FAIL

[Consume Int8Array request's body as arrayBuffer]
[Consume ArrayBuffer request's body as arrayBuffer]
expected: FAIL
[Consume ArrayBuffer request's body as text]
[Consume ArrayBuffer request's body as JSON]
expected: FAIL

[Consume Float32Array request's body as blob]
[Consume Uint8Array request's body as text]
expected: FAIL
[Consume Float32Array request's body as arrayBuffer]
[Consume Uint8Array request's body as blob]
expected: FAIL

[Consume Float32Array request's body as JSON]
[Consume Uint8Array request's body as arrayBuffer]
expected: FAIL
[Consume DataView request's body as text]
[Consume Uint8Array request's body as JSON]
expected: FAIL

[Consume DataView request's body as blob]
[Consume Int8Array request's body as JSON]
expected: FAIL
[Consume DataView request's body as arrayBuffer]
[Consume Float32Array request's body as text]
expected: FAIL

[Consume DataView request's body as JSON]
[Consume ArrayBuffer request's body as text]
expected: FAIL
[Consume FormData request's body as FormData]
[Consume Int8Array request's body as text]
expected: FAIL

[Consume ArrayBuffer request's body as blob]
[Consume Int8Array request's body as blob]
expected: FAIL
[Consume ArrayBuffer request's body as arrayBuffer]
[Consume Int8Array request's body as arrayBuffer]
expected: FAIL

[Consume ArrayBuffer request's body as JSON]
[Consume Float32Array request's body as blob]
expected: FAIL
[Consume Uint8Array request's body as text]
[Consume Float32Array request's body as arrayBuffer]
expected: FAIL

[Consume Uint8Array request's body as blob]
[Consume Float32Array request's body as JSON]
expected: FAIL
[Consume Uint8Array request's body as arrayBuffer]
[Consume DataView request's body as text]
expected: FAIL

[Consume Uint8Array request's body as JSON]
[Consume DataView request's body as blob]
expected: FAIL
[Consume Int8Array request's body as JSON]
[Consume DataView request's body as arrayBuffer]
expected: FAIL

[Consume Float32Array request's body as text]
[Consume DataView request's body as JSON]
expected: FAIL
5 tests/wpt/metadata/xhr/send-data-arraybuffer.htm.ini
View file
Open in desktop

This file was deleted.

5 tests/wpt/metadata/xhr/send-data-arraybufferview.htm.ini
View file
Open in desktop

This file was deleted.

6 tests/wpt/metadata/xhr/setrequestheader-content-type.htm.ini
View file
Open in desktop
@@ -1,14 +1,8 @@
[setrequestheader-content-type.htm]
type: testharness
[ArrayBuffer request sends no Content-Type without setRequestHeader() call]
expected: FAIL

[ArrayBuffer request keeps setRequestHeader() Content-Type and charset]
expected: FAIL

[ArrayBufferView request sends no Content-Type without setRequestHeader() call]
expected: FAIL

[ArrayBufferView request keeps setRequestHeader() Content-Type and charset]
expected: FAIL

29 tests/wpt/mozilla/meta/MANIFEST.json
View file
Open in desktop
@@ -11593,11 +11593,6 @@
{}
]
],
"mozilla/resources/content.py": [
[
{}
]
],
"mozilla/resources/external.js": [
[
{}
{}
]
],
"mozilla/send-arraybuffer.htm": [
[
"/_mozilla/mozilla/send-arraybuffer.htm",
{}
]
],
"mozilla/send-blob.htm": [
[
"/_mozilla/mozilla/send-blob.htm",
{}
]
],
"mozilla/sequence-hole.html": [
[
"/_mozilla/mozilla/sequence-hole.html",
"1a76b81400b1e150f008d11180adcdf786e77b67",
"support"
],
"mozilla/resources/content.py": [
"5cf25421cc9c0e0f88a159b363f99f37036d019f",
"support"
],
"mozilla/resources/external.js": [
"78686147f85e4146e7fc58c1f67a613f65b099a2",
"support"
"fc757effccd93c56ab79b0510a01ae815b7a8714",
"testharness"
],
"mozilla/send-arraybuffer.htm": [
"dc04c6f888458b28bd29a3a43f4dab7f12e72a33",
"testharness"
],
"mozilla/send-blob.htm": [
"5d8d62c0c2c27edbb875183a31a9005c950141cc",
"testharness"
],
"mozilla/sequence-hole.html": [
"db0cc2660c8d937ccf6e3334c92dc48208c69841",
"testharness"
18 tests/wpt/mozilla/tests/mozilla/resources/content.py
View file
Open in desktop

This file was deleted.

50 tests/wpt/mozilla/tests/mozilla/send-arraybuffer.htm
View file
Open in desktop

This file was deleted.

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.