Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to rustc 1.25.0-nightly (bacb5c58d 2018-01-26) #20454

Merged
merged 2 commits into from Mar 29, 2018
Merged

Conversation

@emilio
Copy link
Member

emilio commented Mar 27, 2018

This change is Reviewable

emilio added 2 commits Mar 27, 2018
These warn with the next Nightly.
@highfive
Copy link

highfive commented Mar 27, 2018

Heads up! This PR modifies the following files:

  • @bholley: components/selectors/attr.rs, components/selectors/parser.rs
@SimonSapin
Copy link
Member

SimonSapin commented Mar 27, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2018

📌 Commit 9039a64 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2018

Testing commit 9039a64 with merge 0bc6e10...

bors-servo added a commit that referenced this pull request Mar 27, 2018
Rustup

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20454)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2018

💔 Test failed - linux-rel-css

@SimonSapin
Copy link
Member

SimonSapin commented Mar 27, 2018

  ▶ Unexpected subtest result in /_mozilla/mozilla/getBoundingClientRect.html:
  │ FAIL [expected PASS] Untitled 1
  │   → assert_equals: expected 62 but got 60.35
  │ 
  │ test_rect@http://web-platform.test:8000/_mozilla/mozilla/getBoundingClientRect.html:59:7
  │ @http://web-platform.test:8000/_mozilla/mozilla/getBoundingClientRect.html:86:9
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1494:20
  │ test@http://web-platform.test:8000/resources/testharness.js:511:9
  └ @http://web-platform.test:8000/_mozilla/mozilla/getBoundingClientRect.html:82:5
@SimonSapin SimonSapin changed the title Rustup Update to rust version 1.26.0-nightly (188e693b3 2018-03-26) Mar 29, 2018
@SimonSapin
Copy link
Member

SimonSapin commented Mar 29, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Mar 29, 2018

Testing commit 9039a64 with merge d232705...

bors-servo added a commit that referenced this pull request Mar 29, 2018
Update to rust version 1.26.0-nightly (188e693b3 2018-03-26)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20454)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 29, 2018

💔 Test failed - linux-rel-css

@SimonSapin
Copy link
Member

SimonSapin commented Mar 29, 2018


  ▶ CRASH [expected ERROR] /referrer-policy/unsafe-url/http-rp/cross-origin/http-https/img-tag/generic.swap-origin-redirect.http.html
  │ 
  │ VMware, Inc.
  │ softpipe
  │ 3.3 (Core Profile) Mesa 17.3.0-devel
  │ called `Result::unwrap()` on an `Err` value: Io(Os { code: 104, kind: ConnectionReset, message: "Connection reset by peer" }) (thread main, at libcore/result.rs:945)
  │ ERROR 2018-03-29T13:46:01Z: script::dom::bindings::error: Error at :0:0 SecurityError: The operation is insecure.
  │ ERROR 2018-03-29T13:46:01Z: script::dom::bindings::error: Error at :0:0 SecurityError: The operation is insecure.
  │ ERROR 2018-03-29T13:46:01Z: script::dom::bindings::error: Error at :0:0 SecurityError: The operation is insecure.
  │ ERROR 2018-03-29T13:46:01Z: script::dom::bindings::error: Error at :0:0 SecurityError: The operation is insecure.
  │ ERROR 2018-03-29T13:46:01Z: script::dom::bindings::error: Error at :0:0 SecurityError: The operation is insecure.
  │ stack backtrace:
  │    0:     0x7f94461458cc - backtrace::backtrace::trace::heb9efa3021143bc0
  │    1:     0x7f9446144c52 - backtrace::capture::Backtrace::new::hd20e533c9c999e36
  │    2:     0x7f944314669c - servo::main::{{closure}}::h96f2fd035380f7d9
  │    3:     0x7f9446154465 - std::panicking::rust_panic_with_hook::h489260a27605eec3
  │                         at libstd/panicking.rs:577
  │    4:     0x7f944615427e - std::panicking::begin_panic::h76e4e10033758ab0
  │                         at libstd/panicking.rs:537
  │    5:     0x7f94461541ea - std::panicking::begin_panic_fmt::h89311252f4057b32
  │                         at libstd/panicking.rs:521
  │    6:     0x7f9446154182 - rust_begin_unwind
  │                         at libstd/panicking.rs:497
  │    7:     0x7f944618ad40 - core::panicking::panic_fmt::h742dc08d23c8d154
  │                         at libcore/panicking.rs:71
  │    8:     0x7f94458a9ced - core::result::unwrap_failed::he5b4c8ef88d0cfcf
  │    9:     0x7f94458968b9 - webrender_api::api::RenderApi::get_scroll_node_state::h0e7fc5ec325096a2
  │   10:     0x7f9443166d5a - <compositing::compositor::IOCompositor<Window>>::send_viewport_rects::h92f4b62c465645f2
  │   11:     0x7f9443168120 - _ZN60_$LT$compositing..compositor..IOCompositor$LT$Window$GT$$GT$22handle_browser_message17hd3068794eb6fe2a5E.llvm.91EDB212
  │   12:     0x7f94431657c7 - <compositing::compositor::IOCompositor<Window>>::receive_messages::hce9c94c6e243783d
  │   13:     0x7f944313672b - <servo::Servo<Window>>::handle_events::h5362d2967f3a7429
  │   14:     0x7f9443152453 - servo::main::{{closure}}::h4bcb822908160ac8
  │   15:     0x7f944314c4e8 - servo::glutin_app::window::Window::run::hc4dad2185b3d5142
  │   16:     0x7f944314580e - servo::main::h77e7a2d85e964b56
  │   17:     0x7f9443146a82 - std::rt::lang_start::{{closure}}::h17fcc6030673dc3b
  │   18:     0x7f94461540e7 - std::rt::lang_start_internal::{{closure}}::h3b2f04b904715533
  │                         at libstd/rt.rs:59
  │                          - std::panicking::try::do_call::h982938453be85532
  │                         at libstd/panicking.rs:479
  │   19:     0x7f944617dafe - __rust_maybe_catch_panic
  │                         at libpanic_unwind/lib.rs:102
  │   20:     0x7f94461613f3 - std::panicking::try::h0137c31626fca698
  │                         at libstd/panicking.rs:458
  │                          - std::panic::catch_unwind::hb39d856d498e31e1
  │                         at libstd/panic.rs:358
  │                          - std::rt::lang_start_internal::h3578ac5ff98f3d4e
  │                         at libstd/rt.rs:58
  │   21:     0x7f9443146943 - main
  │   22:     0x7f9440822f44 - __libc_start_main
  │   23:     0x7f9443103da3 - <unknown>
  │   24:                0x0 - <unknown>
  └ ERROR 2018-03-29T13:46:02Z: servo: called `Result::unwrap()` on an `Err` value: Io(Os { code: 104, kind: ConnectionReset, message: "Connection reset by peer" })
@jdm
Copy link
Member

jdm commented Mar 29, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Mar 29, 2018

@SimonSapin SimonSapin changed the title Update to rust version 1.26.0-nightly (188e693b3 2018-03-26) Update to rustc 1.25.0-nightly (bacb5c58d 2018-01-26) Mar 29, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Mar 29, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: SimonSapin
Pushing d232705 to master...

@bors-servo bors-servo merged commit 9039a64 into servo:master Mar 29, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@emilio emilio deleted the emilio:rustup branch Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.