Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nsCSSPseudoClasses and friends #20456

Merged
merged 4 commits into from Mar 27, 2018
Merged

Remove nsCSSPseudoClasses and friends #20456

merged 4 commits into from Mar 27, 2018

Conversation

@upsuper
Copy link
Member

upsuper commented Mar 27, 2018 •
edited by SimonSapin

This is the Servo side change of bug 1449097 and bug 1449089.

This change is Reviewable
upsuper added 4 commits Mar 27, 2018
@upsuper
Use Servo to implement GetStatesForPseudoClass function in InspectorU…
bb15111 
…tils.
@upsuper
Make :-moz-native-anonymous and :-moz-use-shadow-tree-root matches in…
911f174 
… Rust code.
@upsuper
Move matching logic of :-moz-table-border-nonzero and :-moz-browser-f…
e57b6c6 
…rame into individual binding functions.
@upsuper
Remove nsCSSPseudoClasses.{h,cpp} and nsCSSPseudoClassList.h.
Loading status checks…
688fb23
@highfive
Copy link

highfive commented Mar 27, 2018

Heads up! This PR modifies the following files:

  • @bholley: ports/geckolib/glue.rs, components/style/gecko/generated/structs.rs, components/style/gecko/generated/bindings.rs, components/style/gecko/selector_parser.rs, components/style/gecko/wrapper.rs and 1 more
  • @canaltinova: components/style/gecko/generated/structs.rs, components/style/gecko/generated/bindings.rs, components/style/gecko/selector_parser.rs, components/style/gecko/wrapper.rs, components/style/gecko/non_ts_pseudo_class_list.rs
  • @emilio: ports/geckolib/glue.rs, components/style/gecko/generated/structs.rs, components/style/gecko/generated/bindings.rs, components/style/gecko/selector_parser.rs, components/style/gecko/wrapper.rs and 1 more
@highfive
Copy link

highfive commented Mar 27, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@upsuper
Copy link
Member Author

upsuper commented Mar 27, 2018

@bors-servo r=emilio p=1
@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2018

📌 Commit 688fb23 has been approved by emilio
@highfive highfive assigned emilio and unassigned asajeffrey Mar 27, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2018

⌛ Testing commit 688fb23 with merge 97c12bd...
bors-servo added a commit that referenced this pull request Mar 27, 2018
@bors-servo
Auto merge of #20456 - upsuper:remove-nscsspseudoclasses, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
97c12bd 
Remove nsCSSPseudoClasses and friends

This is the Servo side change of [bug 1449097](https://bugzilla.mozilla.org/show_bug.cgi?id=1449097) and [bug 1449089](https://bugzilla.mozilla.org/show_bug.cgi?id=1449089).
@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2018

💔 Test failed - linux-rel-css
@upsuper
Copy link
Member Author

upsuper commented Mar 27, 2018 •
edited

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2018

⚡ Previous build results for android, arm32, linux-dev, linux-rel-wpt, mac-dev-unit are reusable. Rebuilding only arm64, linux-rel-css, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2018

⚡ Previous build results for android, arm32, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-wpt3 are reusable. Rebuilding only arm64, linux-rel-css, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt4, windows-msvc-dev...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 27, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 97c12bd to master...
@bors-servo bors-servo merged commit 688fb23 into servo:master Mar 27, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@upsuper upsuper deleted the upsuper-forks:remove-nscsspseudoclasses branch Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@upsuper @highfive @bors-servo @asajeffrey @emilio
You can’t perform that action at this time.