Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAvoid ./mach build to clobber the build by default. #20491
Conversation
highfive
commented
Mar 31, 2018
|
Heads up! This PR modifies the following files:
|
|
r? @jdm @bors-servo try |
Avoid ./mach build to clobber the build by default. Fixes #20489. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20491) <!-- Reviewable:end -->
|
Not sure if the WITH_GOLD bit will make the ARM build fail... I guess we'll see. |
|
Not sure if the tradeoff is worth disabling the gold linker by default :/ |
|
|
It definitely is for me, but if you think otherwise I can try to find another solution... Not clear to me how'd that look. |
|
It might be worth taking this to the mailing list. I'm on leave this month, so I'm unassigning myself. |
|
@emilio What's the status on this? |
|
I mailed the list. Not sure if we should proceed here or not, I guess @SimonSapin tried to make the gold bits use the cargo config and hit a cargo bug. |
|
My hope was to move the "unused |
|
Given the downsides, I'm going to close this. |
emilio commentedMar 31, 2018
•
edited by SimonSapin
Fixes #20489.
This change is