Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Document.createElementNS. #2053

Merged
merged 1 commit into from Apr 7, 2014
Merged

Implement Document.createElementNS. #2053

merged 1 commit into from Apr 7, 2014

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 7, 2014

#1391 rebased
@therealglazou @Ms2ger
Implement Document.createElementNS.
Loading status checks…
4b0da08
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 7, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1182

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@Ms2ger Ms2ger mentioned this pull request Apr 7, 2014
Closed
@jdm

This comment has been minimized.

Sign in to view
Copy link

jdm commented on 4b0da08 Apr 7, 2014

r+
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 4b0da08 Apr 7, 2014

saw approval from jdm
at Ms2ger@4b0da08

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 7, 2014

merging Ms2ger/servo/createElementNS = 4b0da08 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 7, 2014

Ms2ger/servo/createElementNS = 4b0da08 merged ok, testing candidate = f9c9e62

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 7, 2014

all tests pass:
success: http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/1170
success: http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/1125

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 7, 2014

fast-forwarding master to auto = f9c9e62
bors-servo pushed a commit that referenced this pull request Apr 7, 2014
bors-servo
auto merge of #2053 : Ms2ger/servo/createElementNS, r=jdm
f9c9e62 
#1391 rebased
@bors-servo bors-servo merged commit 4b0da08 into servo:master Apr 7, 2014
1 check passed
1 check passed
default all tests passed
@Ms2ger Ms2ger deleted the Ms2ger:createElementNS branch Apr 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @hoppipolla-critic-bot @bors-servo @jdm @therealglazou
You can’t perform that action at this time.