Update cssparser and related dependencies #20564

mbrubeck · 2018-04-05T16:40:31Z

Includes an update to num-traits 0.1.43 which is a compatibility wrapper for 0.2.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes do not require tests because no code changes

This change is


        Update cssparser and related dependencies

highfive · 2018-04-05T16:40:35Z

Heads up! This PR modifies the following files:

@bholley: components/style/Cargo.toml
@canaltinova: components/style/Cargo.toml
@edunham: servo-tidy.toml
@emilio: components/style/Cargo.toml

highfive · 2018-04-05T16:40:37Z

Warning

These commits modify style code, but no tests are modified. Please consider adding a test!

Eijebong · 2018-04-06T11:46:06Z

servo-tidy.toml

@@ -44,6 +44,7 @@ packages = [
  "quote",
  "unicode-xid",
  "log",
+  "num-traits",


nox · 2018-04-09T09:11:38Z

@mbrubeck Please file an issue about having to deduplicate num-traits, but r=me apart from that.

Eijebong · 2018-04-09T09:12:46Z

@nox #20356

nox · 2018-04-09T09:13:32Z

@bors-servo r+

Thanks @Eijebong.

bors-servo · 2018-04-09T09:13:33Z

📌 Commit d97e021 has been approved by nox

bors-servo · 2018-04-09T10:23:46Z

⌛ Testing commit d97e021 with merge 8388a1a...


        Auto merge of #20564 - mbrubeck:deps, r=nox

Update cssparser and related dependencies Includes an update to num-traits 0.1.43 which is a compatibility wrapper for 0.2. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because no code changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20564)

bors-servo · 2018-04-09T10:41:56Z

💔 Test failed - windows-msvc-dev


        Dedupe syn, quote and unicode-xid

Dupe num-traits instead... Fixes servo#20497 Fixes servo#19786 Closes servo#20564


        Dedupe syn, quote and unicode-xid

Dupe num-traits instead... Fixes servo#20497 Fixes servo#19786 Closes servo#20564


        Dedupe syn, quote and unicode-xid

Dupe num-traits instead... Fixes servo#20497 Fixes servo#19786 Closes servo#20564


        Dedupe syn, quote and unicode-xid

Dupe num-traits instead... Fixes servo#20497 Fixes servo#19786 Closes servo#20564


        Dedupe syn, quote and unicode-xid

Dupe num-traits instead... Fixes servo#20497 Fixes servo#19786 Closes servo#20564


        Dedupe syn, quote and unicode-xid

Dupe num-traits instead... Fixes servo#20497 Fixes servo#19786 Closes servo#20564


        Dedupe syn, quote and unicode-xid

Dupe num-traits instead... Fixes servo#20497 Fixes servo#19786 Closes servo#20564


        Dedupe syn, quote and unicode-xid

Dupe num-traits instead... Fixes servo#20609 Fixes servo#20497 Fixes servo#19786 Closes servo#20564


        Auto merge of #20611 - Eijebong:(╯°□°）╯︵sǝdnp, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20611)


        Dedupe syn, quote and unicode-xid

Dupe num-traits instead... Fixes servo#20609 Fixes servo#20497 Fixes servo#19786 Closes servo#20564


        Auto merge of #20611 - Eijebong:(╯°□°）╯︵sǝdnp, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20611)

Eijebong · 2018-04-19T22:47:22Z

Funnily enough, I don't get this in #20649


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)


        Dedupe syn, quote and unicode-xid

Dupe num-traits instead... Fixes servo#20609 Fixes servo#20497 Fixes servo#19786 Closes servo#20564


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=nox

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)

bors-servo · 2018-04-25T10:20:35Z

☔ The latest upstream changes (presumably #20690) made this pull request unmergeable. Please resolve the merge conflicts.


        Dedupe syn, quote, unicode-xid itoa

Fixes servo#20497 Fixes servo#19786 Closes servo#20564


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)


        Dedupe syn, quote, itoa and unicode-xid

Fixes servo#20497 Fixes servo#19786 Closes servo#20564


        Dedupe syn, quote, itoa and unicode-xid

Fixes servo#20497 Fixes servo#19786 Closes servo#20564


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)


        Dedupe syn, quote, itoa and unicode-xid

Fixes servo#20497 Fixes servo#19786 Closes servo#20564


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=nox

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)


        Dedupe syn, quote, itoa and unicode-xid

Fixes servo#20497 Fixes servo#19786 Closes servo#20564


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)


        Dedupe syn, quote and unicode-xid

Fixes servo#20609 Fixes servo#20497 Fixes servo#19786 Closes servo#20564


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=Sim…

…onSapin Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)

Update cssparser and related dependencies

Loading status checks…

d97e021

highfive assigned nox Apr 5, 2018

highfive added the S-awaiting-review label Apr 5, 2018

Eijebong reviewed Apr 6, 2018

View changes

servo-tidy.toml

@@ -44,6 +44,7 @@ packages = [

"quote",

"unicode-xid",

"log",

"num-traits",

This comment has been minimized.

Sign in to view

Eijebong Apr 6, 2018
Member

😭

nox approved these changes Apr 9, 2018

View changes

nox removed the S-awaiting-review label Apr 9, 2018

highfive added the S-awaiting-merge label Apr 9, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Apr 9, 2018

Eijebong added a commit to Eijebong/servo that referenced this pull request Apr 10, 2018

Dedupe syn, quote and unicode-xid

97cf76b

Dupe num-traits instead... Fixes servo#20497 Fixes servo#19786 Closes servo#20564

Eijebong mentioned this pull request Apr 10, 2018

Dedupe syn, quote and unicode-xid #20611

Closed

Eijebong added a commit to Eijebong/servo that referenced this pull request Apr 10, 2018

Dedupe syn, quote and unicode-xid

4912bf8

Dupe num-traits instead... Fixes servo#20497 Fixes servo#19786 Closes servo#20564

Eijebong added a commit to Eijebong/servo that referenced this pull request Apr 10, 2018

Dedupe syn, quote and unicode-xid

a34af31

Dupe num-traits instead... Fixes servo#20497 Fixes servo#19786 Closes servo#20564

Eijebong added a commit to Eijebong/servo that referenced this pull request Apr 10, 2018

Dedupe syn, quote and unicode-xid

84b5dc4

Dupe num-traits instead... Fixes servo#20497 Fixes servo#19786 Closes servo#20564

Eijebong added a commit to Eijebong/servo that referenced this pull request Apr 10, 2018

Dedupe syn, quote and unicode-xid

858347b

Dupe num-traits instead... Fixes servo#20497 Fixes servo#19786 Closes servo#20564

Eijebong added a commit to Eijebong/servo that referenced this pull request Apr 10, 2018

Dedupe syn, quote and unicode-xid

223ee49

Dupe num-traits instead... Fixes servo#20497 Fixes servo#19786 Closes servo#20564

Eijebong added a commit to Eijebong/servo that referenced this pull request Apr 10, 2018

Dedupe syn, quote and unicode-xid

f1b8aca

Dupe num-traits instead... Fixes servo#20497 Fixes servo#19786 Closes servo#20564

Eijebong added a commit to Eijebong/servo that referenced this pull request Apr 10, 2018

Dedupe syn, quote and unicode-xid

d3c4228

Dupe num-traits instead... Fixes servo#20609 Fixes servo#20497 Fixes servo#19786 Closes servo#20564

Eijebong added a commit to Eijebong/servo that referenced this pull request Apr 10, 2018

Dedupe syn, quote and unicode-xid

9e21b53

Dupe num-traits instead... Fixes servo#20609 Fixes servo#20497 Fixes servo#19786 Closes servo#20564

Eijebong added a commit to Eijebong/servo that referenced this pull request Apr 20, 2018

Dedupe syn, quote and unicode-xid

01dc3a2

Dupe num-traits instead... Fixes servo#20609 Fixes servo#20497 Fixes servo#19786 Closes servo#20564

highfive added the S-needs-rebase label Apr 25, 2018

Eijebong added a commit to Eijebong/servo that referenced this pull request Apr 27, 2018

Dedupe syn, quote, unicode-xid itoa

e67913f

Fixes servo#20497 Fixes servo#19786 Closes servo#20564

Eijebong added a commit to Eijebong/servo that referenced this pull request Apr 27, 2018

Dedupe syn, quote, itoa and unicode-xid

e853f2b

Fixes servo#20497 Fixes servo#19786 Closes servo#20564

Eijebong added a commit to Eijebong/servo that referenced this pull request Apr 27, 2018

Dedupe syn, quote, itoa and unicode-xid

c721069

Fixes servo#20497 Fixes servo#19786 Closes servo#20564

Eijebong added a commit to Eijebong/servo that referenced this pull request May 1, 2018

Dedupe syn, quote, itoa and unicode-xid

83a6c7f

Fixes servo#20497 Fixes servo#19786 Closes servo#20564

Eijebong added a commit to Eijebong/servo that referenced this pull request May 2, 2018

Dedupe syn, quote, itoa and unicode-xid

5fd6fed

Fixes servo#20497 Fixes servo#19786 Closes servo#20564

Eijebong added a commit to Eijebong/servo that referenced this pull request May 24, 2018

Dedupe syn, quote and unicode-xid

e1fe47a

Fixes servo#20609 Fixes servo#20497 Fixes servo#19786 Closes servo#20564

bors-servo closed this in #20649 May 24, 2018

servo / servo

Update cssparser and related dependencies #20564

Update cssparser and related dependencies #20564

mbrubeck commented Apr 5, 2018 •

edited by SimonSapin

highfive commented Apr 5, 2018

highfive commented Apr 5, 2018

This comment has been minimized.

nox commented Apr 9, 2018

Eijebong commented Apr 9, 2018

nox commented Apr 9, 2018

bors-servo commented Apr 9, 2018

bors-servo commented Apr 9, 2018

bors-servo commented Apr 9, 2018

Eijebong commented Apr 19, 2018

bors-servo commented Apr 25, 2018

servo / servo

Join GitHub today

Update cssparser and related dependencies #20564

Update cssparser and related dependencies #20564

Conversation

mbrubeck commented Apr 5, 2018 • edited by SimonSapin

highfive commented Apr 5, 2018

highfive commented Apr 5, 2018

This comment has been minimized.

Eijebong Apr 6, 2018

nox commented Apr 9, 2018

Eijebong commented Apr 9, 2018

nox commented Apr 9, 2018

bors-servo commented Apr 9, 2018

bors-servo commented Apr 9, 2018

bors-servo commented Apr 9, 2018

Eijebong commented Apr 19, 2018

bors-servo commented Apr 25, 2018

mbrubeck commented Apr 5, 2018 •

edited by SimonSapin