Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace initial about:blank loads #20579

Merged
merged 2 commits into from Apr 11, 2018
Merged

Replace initial about:blank loads #20579

merged 2 commits into from Apr 11, 2018

Conversation

@cbrewster
Copy link
Member

cbrewster commented Apr 7, 2018 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach build-geckolib does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #14720 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@highfive
Copy link

highfive commented Apr 7, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/htmliframeelement.rs
  • @fitzgen: components/script/dom/htmliframeelement.rs
  • @KiChjang: components/script/dom/htmliframeelement.rs
@highfive
Copy link

highfive commented Apr 7, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@cbrewster
Copy link
Member Author

cbrewster commented Apr 7, 2018

r? @asajeffrey
@bors-servo try
@highfive highfive assigned asajeffrey and unassigned glennw Apr 7, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2018

⌛ Trying commit 78e6adb with merge 6fac5b8...
bors-servo added a commit that referenced this pull request Apr 7, 2018
@bors-servo
Auto merge of #20579 - cbrewster:about_blank_replace, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6fac5b8 
Replace initial about:blank loads

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach build-geckolib` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14720 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20579)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2018

💔 Test failed - linux-rel-wpt
@asajeffrey
Copy link
Member

asajeffrey commented Apr 9, 2018

Well this all looks perfectly sensible, I wonder why WPT is failing? It's a pity we're using an extra pipeline id per iframe, but I don't really see how to avoid that.
@cbrewster
Copy link
Member Author

cbrewster commented Apr 9, 2018

@asajeffrey I'm going through each of the failures, they seem to be due to other issues. I'll update the test expectations with links to their relevant issues.
@cbrewster cbrewster force-pushed the cbrewster:about_blank_replace branch from 78e6adb to f816d2f Apr 10, 2018
@cbrewster cbrewster force-pushed the cbrewster:about_blank_replace branch from f816d2f to c3c6c3e Apr 10, 2018
@cbrewster
Copy link
Member Author

cbrewster commented Apr 10, 2018 •
edited

Updated test expectations. New TIMEOUTs are due to #20604
cbrewster added 2 commits Apr 10, 2018
@cbrewster
Update pipeline activity before closing pipelines
004549d
@cbrewster
Replace initial about:blank loads
Loading status checks…
5f85824
@cbrewster cbrewster force-pushed the cbrewster:about_blank_replace branch from c3c6c3e to 5f85824 Apr 11, 2018
@asajeffrey
Copy link
Member

asajeffrey commented Apr 11, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2018

📌 Commit 5f85824 has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2018

⌛ Testing commit 5f85824 with merge ae117be...
bors-servo added a commit that referenced this pull request Apr 11, 2018
@bors-servo
Auto merge of #20579 - cbrewster:about_blank_replace, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ae117be 
Replace initial about:blank loads

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach build-geckolib` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14720 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20579)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2018

💔 Test failed - linux-rel-css
@asajeffrey
Copy link
Member

asajeffrey commented Apr 11, 2018 

{"status": "FAIL", "group": "default", "message": "assert_equals: Name is first-contentful-paint expected \"first-contentful-paint\" but got \"first-paint\"", "stack": "observer</<@http://web-platform.test:8000/_mozilla/mozilla/paint_timing.html:11:5\nobserver<@http://web-platform.test:8000/_mozilla/mozilla/paint_timing.html:9:3\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1501:20\nTest.prototype.step_func_done/<@http://web-platform.test:8000/resources/testharness.js:1541:17\n", "subtest": "Performance entries observer", "test": "/_mozilla/mozilla/paint_timing.html", "line": 103759, "action": "test_result", "expected": "PASS"}
@asajeffrey
Copy link
Member

asajeffrey commented Apr 11, 2018

IRC conversation with @avadacatavra https://mozilla.logbot.info/servo/20180411#c14594227
@asajeffrey
Copy link
Member

asajeffrey commented Apr 11, 2018

Oh great, I can't replicate the failure at my end. Let's retry it and see if it's an intermittent failure.

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, mac-rel-css2...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: asajeffrey
Pushing ae117be to master...
@bors-servo bors-servo merged commit 5f85824 into servo:master Apr 11, 2018
3 of 4 checks passed
3 of 4 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@asajeffrey asajeffrey mentioned this pull request Apr 11, 2018
Open
@asajeffrey
Copy link
Member

asajeffrey commented Apr 11, 2018

Looks like it was intermittent #20625.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asajeffrey asajeffrey

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Iframes always load with about:blank in history
5 participants
@cbrewster @highfive @bors-servo @asajeffrey @glennw
You can’t perform that action at this time.