Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rust toolchain to 2018-03-24. #20589

Closed
wants to merge 5 commits into from
Closed

Conversation

@mrowqa
Copy link

mrowqa commented Apr 8, 2018

Newer toolchain contains bugfix required by #14902.


  • ./mach build -d does not report any errors
    It reports some warnings about deprecated items in rust-webvr-api.
  • ./mach build-geckolib does not report any errors
  • ./mach test-tidy does not report any errors

This change is Reviewable

@highfive
Copy link

highfive commented Apr 8, 2018

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @mbrubeck (or someone else) soon.

mrowqa added 2 commits Apr 8, 2018
@mrowqa
Copy link
Author

mrowqa commented Apr 8, 2018

Taking a look at this it seems like NonZero i Zeroable have been removed, so I have left only the manual implementation of it.
CC @nikomatsakis

unsafe { BrowsingContextIndex(NonZero::new_unchecked(8765)) };
#[cfg(feature = "unstable")]
pub const TEST_BROWSING_CONTEXT_ID: BrowsingContextId =
BrowsingContextId { namespace_id: TEST_NAMESPACE, index: TEST_BROWSING_CONTEXT_INDEX };

This comment has been minimized.

Copy link
@mrowqa

mrowqa Apr 8, 2018

Author

Failed with:

error[E0015]: calls in constants are limited to constant functions, struct and enum constructors
   --> components/msg/constellation_msg.rs:358:71
    |
358 | pub const TEST_PIPELINE_INDEX: PipelineIndex = unsafe { PipelineIndex(NonZero::new_unchecked(5678)) };
    |                                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0015]: calls in constants are limited to constant functions, struct and enum constructors
   --> components/msg/constellation_msg.rs:364:35
    |
364 |     unsafe { BrowsingContextIndex(NonZero::new_unchecked(8765)) };
    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to 2 previous errors
@SimonSapin
Copy link
Member

SimonSapin commented Apr 8, 2018

This will likely hit the same WebBluetooth test failures as #20474 (comment) which still need to be investigated.

@SimonSapin
Copy link
Member

SimonSapin commented Apr 8, 2018

By the way #20474 already takes care of the nonzero stuff.

@mrowqa mrowqa mentioned this pull request Apr 8, 2018
0 of 3 tasks complete
@mrowqa
Copy link
Author

mrowqa commented Apr 8, 2018

Oh, I haven't noticed this PR. In this case my change looks redundant.

@mrowqa mrowqa closed this Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.