Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Four nondescript WebGL improvements #20598

Merged
merged 4 commits into from Apr 10, 2018
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Fix filtering of reserved WebGL names in gl.getAttribLocation

  • Loading branch information
nox committed Apr 9, 2018
commit 561c41097fc5577f9747a205af29e443ace73a0a
@@ -306,7 +306,8 @@ impl WebGLProgram {
return Err(WebGLError::InvalidOperation);
}

if name.starts_with("webgl") || name.starts_with("_webgl_") {
// https://www.khronos.org/registry/webgl/specs/latest/1.0/#GLSL_CONSTRUCTS
if name.starts_with("webgl_") || name.starts_with("_webgl_") {
return Ok(None);
}

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.