Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Four nondescript WebGL improvements #20598

Merged
merged 4 commits into from Apr 10, 2018
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

Fix the error emitted for invalid targets in WebGLTexture::bind

It doesn't actually matter because this is only called from
WebGLRenderingContext::BindTexture, which already checks the target,
but better be safe than sorry.
  • Loading branch information
nox committed Apr 9, 2018
commit 68898f4ebd1a9112b7281ec766a725e24c62205e
@@ -109,7 +109,7 @@ impl WebGLTexture {
let face_count = match target {
constants::TEXTURE_2D => 1,
constants::TEXTURE_CUBE_MAP => 6,
_ => return Err(WebGLError::InvalidOperation)
_ => return Err(WebGLError::InvalidEnum)
};
self.face_count.set(face_count);
self.target.set(Some(target));
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.