Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedupe syn, quote and unicode-xid #20611

Closed
wants to merge 1 commit into from
Closed

Dedupe syn, quote and unicode-xid #20611

wants to merge 1 commit into from

Conversation

@Eijebong
Copy link
Member

Eijebong commented Apr 10, 2018 •
edited

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

This change is Reviewable
@ghost
Copy link

ghost commented Apr 10, 2018

Submitting the task to Taskcluster failed. Details 
Cannot have unicode in branch names!
@ghost
Copy link

ghost commented Apr 10, 2018

Submitting the task to Taskcluster failed. Details 
Cannot have unicode in branch names!
@highfive
Copy link

highfive commented Apr 10, 2018

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml
  • @canaltinova: components/style/Cargo.toml
  • @paulrouget: components/compositing/compositor.rs
  • @emilio: components/layout/display_list/webrender_helpers.rs, components/style/Cargo.toml
@highfive
Copy link

highfive commented Apr 10, 2018

warning Warning warning

  • These commits modify style and layout code, but no tests are modified. Please consider adding a test!
@ghost
Copy link

ghost commented Apr 10, 2018

Submitting the task to Taskcluster failed. Details 
Cannot have unicode in branch names!
1 similar comment
@ghost
Copy link

ghost commented Apr 10, 2018

Submitting the task to Taskcluster failed. Details 
Cannot have unicode in branch names!
@Eijebong
Copy link
Member Author

Eijebong commented Apr 10, 2018

@glennw Could you have a look at the webrender changes ?
This is still missing some releases to be complete but I wanted to be sure that all the webrender related changes were correct
@Eijebong
Eijebong reviewed Apr 10, 2018
View changes
components/layout/display_list/webrender_helpers.rs Outdated
@@ -225,6 +225,7 @@ impl WebRenderDisplayItemConverter for DisplayItem {

builder.push_stacking_context(
&webrender_api::LayoutPrimitiveInfo::new(stacking_context.bounds),
Some(scrolling_id),

This comment has been minimized.

Sign in to view
@Eijebong

Eijebong Apr 10, 2018

Author Member

It's the only ClipId I found in that function. Maybe it should be None ?

This comment has been minimized.

Sign in to view
@glennw

glennw Apr 10, 2018

Member

Yup, should be None for now, to retain existing behavior.
@Eijebong Eijebong force-pushed the Eijebong:(╯°□°）╯︵sǝdnp branch from 9aadd49 to 97cf76b Apr 10, 2018
@ghost
Copy link

ghost commented Apr 10, 2018

Submitting the task to Taskcluster failed. Details 
Cannot have unicode in branch names!
@Eijebong Eijebong changed the title WIP: Dedupe syn, quote and unicode-xid Dedupe syn, quote and unicode-xid Apr 10, 2018
@ghost
Copy link

ghost commented Apr 10, 2018

Submitting the task to Taskcluster failed. Details 
Cannot have unicode in branch names!
1 similar comment
@ghost
Copy link

ghost commented Apr 10, 2018

Submitting the task to Taskcluster failed. Details 
Cannot have unicode in branch names!
@Eijebong Eijebong force-pushed the Eijebong:(╯°□°）╯︵sǝdnp branch from 97cf76b to 4912bf8 Apr 10, 2018
@ghost
Copy link

ghost commented Apr 10, 2018

Submitting the task to Taskcluster failed. Details 
Cannot have unicode in branch names!
@Eijebong Eijebong force-pushed the Eijebong:(╯°□°）╯︵sǝdnp branch from 4912bf8 to a34af31 Apr 10, 2018
@ghost
Copy link

ghost commented Apr 10, 2018

Submitting the task to Taskcluster failed. Details 
Cannot have unicode in branch names!
@Eijebong Eijebong force-pushed the Eijebong:(╯°□°）╯︵sǝdnp branch 3 times, most recently from 858347b to 223ee49 Apr 10, 2018
@ghost
Copy link

ghost commented Apr 10, 2018

Submitting the task to Taskcluster failed. Details 
Cannot have unicode in branch names!
1 similar comment
@ghost
Copy link

ghost commented Apr 10, 2018

Submitting the task to Taskcluster failed. Details 
Cannot have unicode in branch names!
@Eijebong Eijebong force-pushed the Eijebong:(╯°□°）╯︵sǝdnp branch 2 times, most recently from f1b8aca to d3c4228 Apr 10, 2018
@Eijebong
Copy link
Member Author

Eijebong commented Apr 10, 2018

@bors-servo try

Let's see how much stuff I broke
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2018

⌛ Trying commit d3c4228 with merge da8869c...
bors-servo added a commit that referenced this pull request Apr 10, 2018
@bors-servo
Auto merge of #20611 - Eijebong:(╯°□°）╯︵sǝdnp, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
da8869c 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20611)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2018

💔 Test failed - mac-dev-unit
@ghost
Copy link

ghost commented Apr 10, 2018

Submitting the task to Taskcluster failed. Details 
Cannot have unicode in branch names!
@Eijebong Eijebong force-pushed the Eijebong:(╯°□°）╯︵sǝdnp branch from d3c4228 to 9e21b53 Apr 10, 2018
@ghost
Copy link

ghost commented Apr 10, 2018

Submitting the task to Taskcluster failed. Details 
Cannot have unicode in branch names!
@Eijebong
Copy link
Member Author

Eijebong commented Apr 10, 2018

@bors-servo try

Mac build should be fixed
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2018

⌛ Trying commit 9e21b53 with merge d5070f6...
bors-servo added a commit that referenced this pull request Apr 10, 2018
@bors-servo
Auto merge of #20611 - Eijebong:(╯°□°）╯︵sǝdnp, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d5070f6 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20611)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2018

💔 Test failed - mac-rel-css2
@ghost
Copy link

ghost commented Apr 10, 2018

Submitting the task to Taskcluster failed. Details 
Cannot have unicode in branch names!
@Eijebong
Dedupe syn, quote and unicode-xid
Loading status checks…
51c3d5a 
Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564
@Eijebong Eijebong force-pushed the Eijebong:(╯°□°）╯︵sǝdnp branch from 9e21b53 to 51c3d5a Apr 10, 2018
@ghost
Copy link

ghost commented Apr 10, 2018

Submitting the task to Taskcluster failed. Details 
Cannot have unicode in branch names!
@ghost
Copy link

ghost commented Apr 10, 2018

Submitting the task to Taskcluster failed. Details 
Cannot have unicode in branch names!
@Eijebong
Copy link
Member Author

Eijebong commented Apr 11, 2018

@bors-servo try

This time it should be ok >_<
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2018

⌛ Trying commit 51c3d5a with merge a2ebc5f...
bors-servo added a commit that referenced this pull request Apr 11, 2018
@bors-servo
Auto merge of #20611 - Eijebong:(╯°□°）╯︵sǝdnp, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a2ebc5f 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20611)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2018

💔 Test failed - mac-dev-unit
@ghost
Copy link

ghost commented Apr 11, 2018

Submitting the task to Taskcluster failed. Details 
Cannot have unicode in branch names!
@glennw
Copy link
Member

glennw commented Apr 17, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 17, 2018

⌛ Trying commit 51c3d5a with merge 896c93c...
bors-servo added a commit that referenced this pull request Apr 17, 2018
@bors-servo
Auto merge of #20611 - Eijebong:(╯°□°）╯︵sǝdnp, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
896c93c 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20611)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 17, 2018

💔 Test failed - android
@ghost
Copy link

ghost commented Apr 17, 2018

Submitting the task to Taskcluster failed. Details 
Cannot have unicode in branch names!
@glennw
Copy link
Member

glennw commented Apr 17, 2018 

   Compiling style_tests v0.0.1 (file:///home/servo/buildbot/slave/android/build/tests/unit/style)
error[E0432]: unresolved import `libc`
  --> components/gfx/platform/mod.rs:19:9
   |
19 |     use libc::c_char;
   |         ^^^^ Maybe a missing `extern crate libc;`?
@Eijebong Eijebong closed this Apr 17, 2018
@ghost
Copy link

ghost commented Apr 17, 2018

Submitting the task to Taskcluster failed. Details 
Cannot have unicode in branch names!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennw glennw

Assignees

@glennw glennw

Labels
S-awaiting-review S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Eijebong @highfive @bors-servo @glennw
You can’t perform that action at this time.