Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP RFC] Enforce rustfmt on automation. #20617

Closed
wants to merge 1 commit into from
Closed

[WIP RFC] Enforce rustfmt on automation. #20617

wants to merge 1 commit into from

Conversation

@emilio
Copy link
Member

emilio commented Apr 11, 2018 •
edited by SimonSapin

This change is Reviewable
@highfive
Copy link

highfive commented Apr 11, 2018

Heads up! This PR modifies the following files:

  • @aneeshusa: etc/ci/check_rustfmt.sh, etc/ci/buildbot_steps.yml
@emilio
Copy link
Member Author

emilio commented Apr 11, 2018

@bors-servo try

  • (should be green since I changed no rust code)
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2018

⌛ Trying commit a5e3a5d with merge 9ad0173...
bors-servo added a commit that referenced this pull request Apr 11, 2018
@bors-servo
Auto merge of #20617 - emilio:rustfmt, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9ad0173 
Enforce rustfmt on automation.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20617)
<!-- Reviewable:end -->
@emilio emilio changed the title Enforce rustfmt on automation. [WIP RFC] Enforce rustfmt on automation. Apr 11, 2018
@emilio
Copy link
Member Author

emilio commented Apr 11, 2018

@bholley how do you feel about this? We'd need to make an easy way of running this to apply the formatting changes but other than that...
@emilio
Copy link
Member Author

emilio commented Apr 11, 2018

Also, anyone that would like to comment on whether we should do it or not, or maybe just filtering some paths or what not, please let me know. cc @nox / @SimonSapin / @heycam / @Manishearth / anyone else.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2018

💔 Test failed - linux-dev
bors-servo added a commit that referenced this pull request Apr 11, 2018
@bors-servo
Auto merge of #20618 - emilio:rustfmt-smoketest, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b84e331 
[DO NOT MERGE] See if #20617 works.

It should, but just double-checking... :)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20618)
<!-- Reviewable:end -->
@emilio emilio force-pushed the emilio:rustfmt branch from a5e3a5d to c25f597 Apr 11, 2018
@emilio
Copy link
Member Author

emilio commented Apr 11, 2018

Well, tidy failed (lol), but the rustfmt lint itself did not :)
@emilio
Enforce rustfmt on automation.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
3f2667d
@emilio emilio force-pushed the emilio:rustfmt branch from c25f597 to 3f2667d Apr 11, 2018
bors-servo added a commit that referenced this pull request Apr 11, 2018
@bors-servo
Auto merge of #20618 - emilio:rustfmt-smoketest, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fb9bf4b 
[DO NOT MERGE] See if #20617 works.

It should, but just double-checking... :)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20618)
<!-- Reviewable:end -->
@emilio emilio mentioned this pull request Apr 11, 2018
Merged
@jdm jdm mentioned this pull request Aug 9, 2018
Closed
53 of 53 tasks complete
@CYBAI CYBAI mentioned this pull request Nov 6, 2018
Merged
@CYBAI
Copy link
Collaborator

CYBAI commented Nov 7, 2018

Implemented in #22126
@CYBAI CYBAI closed this Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glennw glennw

Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@emilio @highfive @bors-servo @CYBAI @glennw
You can’t perform that action at this time.