Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] See if #20617 works. #20618

Closed
wants to merge 3 commits into from
Closed

[DO NOT MERGE] See if #20617 works. #20618

wants to merge 3 commits into from

Conversation

@emilio
Copy link
Member

emilio commented Apr 11, 2018 •
edited by SimonSapin

It should, but just double-checking... :)

This change is Reviewable
emilio added 2 commits Apr 11, 2018
@emilio
Enforce rustfmt on automation.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
46f8fc6
@emilio
Ensure it works.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
f22faa3
@highfive
Copy link

highfive commented Apr 11, 2018

Heads up! This PR modifies the following files:

  • @bholley: components/selectors/matching.rs
  • @aneeshusa: etc/ci/check_rustfmt.sh, etc/ci/buildbot_steps.yml
@emilio emilio changed the title See if #20617 works. [DO NOT MERGE] See if #20617 works. Apr 11, 2018
@emilio emilio force-pushed the emilio:rustfmt-smoketest branch from 63eea46 to f22faa3 Apr 11, 2018
@emilio
Copy link
Member Author

emilio commented Apr 11, 2018

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2018

⌛ Trying commit f22faa3 with merge b84e331...
bors-servo added a commit that referenced this pull request Apr 11, 2018
@bors-servo
Auto merge of #20618 - emilio:rustfmt-smoketest, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b84e331 
[DO NOT MERGE] See if #20617 works.

It should, but just double-checking... :)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20618)
<!-- Reviewable:end -->
@emilio
Whoops, tail.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
8f24218
@emilio
Copy link
Member Author

emilio commented Apr 11, 2018

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2018

⌛ Trying commit 8f24218 with merge fb9bf4b...
bors-servo added a commit that referenced this pull request Apr 11, 2018
@bors-servo
Auto merge of #20618 - emilio:rustfmt-smoketest, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fb9bf4b 
[DO NOT MERGE] See if #20617 works.

It should, but just double-checking... :)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20618)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 11, 2018

💔 Test failed - linux-dev
@emilio
Copy link
Member Author

emilio commented Apr 11, 2018

well, it does work! http://build.servo.org/builders/linux-dev/builds/11586/steps/shell__1/logs/stdio

But would need to fix whatever issue is causing rustfmt to tweak the comment, afaict the lines passed to it are sane.
@jdm jdm closed this Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
S-awaiting-review S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@emilio @highfive @bors-servo @jdm @Manishearth
You can’t perform that action at this time.