Dedupe syn, quote and unicode-xid #20649

Eijebong · 2018-04-17T08:45:53Z

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

This change is

highfive · 2018-04-17T08:45:57Z

Heads up! This PR modifies the following files:

@bholley: components/style/Cargo.toml
@canaltinova: components/style/Cargo.toml
@edunham: servo-tidy.toml
@paulrouget: components/compositing/compositor.rs
@emilio: components/layout/display_list/webrender_helpers.rs, components/style/Cargo.toml, components/layout/Cargo.toml

highfive · 2018-04-17T08:45:59Z

Warning

These commits modify style, layout, and gfx code, but no tests are modified. Please consider adding a test!

Eijebong · 2018-04-17T08:46:08Z

@bors-servo try

bors-servo · 2018-04-17T08:46:13Z

⌛ Trying commit 16f26fe with merge ea841b1...


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564

bors-servo · 2018-04-17T09:14:18Z

💔 Test failed - linux-rel-css

glennw · 2018-04-19T23:47:27Z

This is the reftest diff for background-color-049.xht. All the diffs I've looked at so far look similar.

The different black box below is drawn via the Ahem CSS testing font. If that's failing to load or using an incorrect glyph, that could explain the difference there. It seems that the missing text description glyphs in the sentences above are likely to be the same problem.

Test image:

Reference image:

glennw · 2018-04-20T00:08:22Z

OK, I fixed the shaping code to use the updated harfbuzz nominal glyph function. That appears to fix the issue above. Let's see what else is broken! 😨

@bors-servo try

bors-servo · 2018-04-20T00:08:27Z

⌛ Trying commit fa4472e with merge 05aca3d...


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)

bors-servo · 2018-04-20T00:34:22Z

💔 Test failed - linux-rel-css

glennw · 2018-04-20T00:38:52Z

Updated test expectations with one new PASS.

@bors-servo try

bors-servo · 2018-04-20T00:38:57Z

⌛ Trying commit 1c15a53 with merge 06f7fb9...


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)

bors-servo · 2018-04-20T01:05:52Z

💔 Test failed - linux-rel-wpt

glennw · 2018-04-20T01:13:09Z

Added another new PASS test update.

@bors-servo try

bors-servo · 2018-04-20T01:13:14Z

⌛ Trying commit 5606834 with merge e8cb8cc...


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)

bors-servo · 2018-04-20T01:44:56Z

💔 Test failed - windows-msvc-dev

Eijebong · 2018-05-02T15:30:49Z

@bors-servo try

Please work

bors-servo · 2018-05-02T15:30:54Z

⌛ Trying commit 5fd6fed with merge 340ee57...


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)

bors-servo · 2018-05-02T15:38:23Z

💔 Test failed - mac-dev-unit

bors-servo · 2018-05-18T20:42:22Z

☔ The latest upstream changes (presumably #20718) made this pull request unmergeable. Please resolve the merge conflicts.


        Dedupe syn, quote and unicode-xid

Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564

Eijebong · 2018-05-24T11:03:18Z

@bors-servo try

Please be magically fixed

bors-servo · 2018-05-24T11:03:23Z

⌛ Trying commit e1fe47a with merge 9d3cb7d...


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>

Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)

bors-servo · 2018-05-24T12:12:11Z

💔 Test failed - mac-rel-wpt3

SimonSapin · 2018-05-24T13:02:34Z

@bors-servo r+

Thanks!

bors-servo · 2018-05-24T13:02:35Z

📌 Commit e1fe47a has been approved by SimonSapin


        Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=Sim…

…onSapin Dedupe syn, quote and unicode-xid Dupe num-traits instead... Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)

bors-servo · 2018-05-24T13:19:31Z

⌛ Testing commit e1fe47a with merge 62c37e0...

bors-servo · 2018-05-24T14:34:43Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: SimonSapin
Pushing 62c37e0 to master...

highfive assigned avadacatavra Apr 17, 2018

highfive added the S-awaiting-review label Apr 17, 2018

highfive added the S-tests-failed label Apr 17, 2018

Eijebong mentioned this pull request Apr 19, 2018

Update cssparser and related dependencies #20564

Closed

3 of 3 tasks complete

highfive removed the S-tests-failed label Apr 20, 2018

highfive added S-tests-failed and removed S-tests-failed labels Apr 20, 2018

highfive added the S-tests-failed label Apr 20, 2018

glennw force-pushed the Eijebong:taskcluster_ruined_all_the_fun branch from 1c15a53 to 5606834 Apr 20, 2018

highfive removed the S-tests-failed label Apr 20, 2018

highfive added the S-tests-failed label Apr 20, 2018

Eijebong force-pushed the Eijebong:taskcluster_ruined_all_the_fun branch from 8b31c66 to 5fd6fed May 2, 2018

highfive removed the S-tests-failed label May 2, 2018

highfive added the S-tests-failed label May 2, 2018

highfive added the S-needs-rebase label May 18, 2018

Dedupe syn, quote and unicode-xid

Loading status checks…

e1fe47a

Fixes #20609 Fixes #20497 Fixes #19786 Closes #20564

Eijebong force-pushed the Eijebong:taskcluster_ruined_all_the_fun branch from 5fd6fed to e1fe47a May 24, 2018

highfive removed the S-tests-failed label May 24, 2018

highfive added the S-tests-failed label May 24, 2018

highfive assigned SimonSapin and unassigned nox May 24, 2018

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-rebase S-tests-failed labels May 24, 2018

bors-servo merged commit e1fe47a into servo:master May 24, 2018
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label May 24, 2018

servo / servo

Dedupe syn, quote and unicode-xid #20649

Dedupe syn, quote and unicode-xid #20649

Eijebong commented Apr 17, 2018 •

edited by SimonSapin

highfive commented Apr 17, 2018

highfive commented Apr 17, 2018

Eijebong commented Apr 17, 2018

bors-servo commented Apr 17, 2018

bors-servo commented Apr 17, 2018

glennw commented Apr 19, 2018

glennw commented Apr 20, 2018

bors-servo commented Apr 20, 2018

bors-servo commented Apr 20, 2018

glennw commented Apr 20, 2018

bors-servo commented Apr 20, 2018

bors-servo commented Apr 20, 2018

glennw commented Apr 20, 2018

bors-servo commented Apr 20, 2018

bors-servo commented Apr 20, 2018

Eijebong commented May 2, 2018

bors-servo commented May 2, 2018

bors-servo commented May 2, 2018

bors-servo commented May 18, 2018

Eijebong commented May 24, 2018

bors-servo commented May 24, 2018

bors-servo commented May 24, 2018

SimonSapin commented May 24, 2018

bors-servo commented May 24, 2018

bors-servo commented May 24, 2018

bors-servo commented May 24, 2018

servo / servo

Join GitHub today

Dedupe syn, quote and unicode-xid #20649

Dedupe syn, quote and unicode-xid #20649

Conversation

Eijebong commented Apr 17, 2018 • edited by SimonSapin

highfive commented Apr 17, 2018

highfive commented Apr 17, 2018

Eijebong commented Apr 17, 2018

bors-servo commented Apr 17, 2018

bors-servo commented Apr 17, 2018

glennw commented Apr 19, 2018

glennw commented Apr 20, 2018

bors-servo commented Apr 20, 2018

bors-servo commented Apr 20, 2018

glennw commented Apr 20, 2018

bors-servo commented Apr 20, 2018

bors-servo commented Apr 20, 2018

glennw commented Apr 20, 2018

bors-servo commented Apr 20, 2018

bors-servo commented Apr 20, 2018

Eijebong commented May 2, 2018

bors-servo commented May 2, 2018

bors-servo commented May 2, 2018

bors-servo commented May 18, 2018

Eijebong commented May 24, 2018

bors-servo commented May 24, 2018

bors-servo commented May 24, 2018

SimonSapin commented May 24, 2018

bors-servo commented May 24, 2018

bors-servo commented May 24, 2018

bors-servo commented May 24, 2018

Eijebong commented Apr 17, 2018 •

edited by SimonSapin