Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #20556: Implement proper checks in WebGLRenderingContext's bindBuffer() #20674

Merged
merged 1 commit into from May 19, 2018
Merged

Issue #20556: Implement proper checks in WebGLRenderingContext's bindBuffer() #20674

merged 1 commit into from May 19, 2018

Conversation

@simartin
Copy link
Contributor

simartin commented Apr 21, 2018 •
edited by SimonSapin

Implement missing check, about deleted buffers.

  • ./mach build -d does not report any errors
  • ./mach build-geckolib does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #20556
  • There are tests for these changes

This change is Reviewable
@highfive
Copy link

highfive commented Apr 21, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webglbuffer.rs
  • @fitzgen: components/script/dom/webglbuffer.rs
  • @KiChjang: components/script/dom/webglbuffer.rs
@nox
Copy link
Member

nox commented Apr 21, 2018

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2018

⌛ Trying commit dc5abc2 with merge 691fddb...
bors-servo added a commit that referenced this pull request Apr 21, 2018
@bors-servo
Auto merge of #20674 - simartin:issue_20556, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
691fddb 
Issue #20556: Implement proper checks in WebGLRenderingContext's bindBuffer()

Implement missing check, about deleted buffers.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach build-geckolib` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20556
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20674)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2018

💔 Test failed - windows-msvc-dev
@simartin
Copy link
Contributor Author

simartin commented Apr 26, 2018

Looks like the windows-msvc-dev tests failed during git fetch. Is there any way to retry them?
@gootorov
Copy link
Contributor

gootorov commented Apr 27, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2018

⌛ Trying commit dc5abc2 with merge 707c38c...
bors-servo added a commit that referenced this pull request Apr 27, 2018
@bors-servo
Auto merge of #20674 - simartin:issue_20556, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
707c38c 
Issue #20556: Implement proper checks in WebGLRenderingContext's bindBuffer()

Implement missing check, about deleted buffers.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach build-geckolib` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20556
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20674)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2018

💔 Test failed - mac-rel-wpt2
@nox
Copy link
Member

nox commented Apr 28, 2018

Weird, I fixed all those websocket issues… Maybe the PR needs a rebase.
@simartin
Issue #20556: Implement proper checks in WebGLRenderingContext's bind…
Loading status checks…
c2fb588 
…Buffer().
@simartin simartin force-pushed the simartin:issue_20556 branch from dc5abc2 to c2fb588 May 10, 2018
@simartin
Copy link
Contributor Author

simartin commented May 10, 2018

PR rebased. Let's see...
@gootorov
Copy link
Contributor

gootorov commented May 10, 2018

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2018

⌛ Trying commit c2fb588 with merge 811beee...
bors-servo added a commit that referenced this pull request May 10, 2018
@bors-servo
Auto merge of #20674 - simartin:issue_20556, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
811beee 
Issue #20556: Implement proper checks in WebGLRenderingContext's bindBuffer()

Implement missing check, about deleted buffers.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach build-geckolib` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20556
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20674)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 10, 2018

💔 Test failed - android
@jdm
Copy link
Member

jdm commented May 18, 2018

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2018

📌 Commit c2fb588 has been approved by nox
@highfive highfive assigned nox and unassigned emilio May 18, 2018
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2018

⌛ Testing commit c2fb588 with merge ba8586f...
bors-servo added a commit that referenced this pull request May 18, 2018
@bors-servo
Auto merge of #20674 - simartin:issue_20556, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ba8586f 
Issue #20556: Implement proper checks in WebGLRenderingContext's bindBuffer()

Implement missing check, about deleted buffers.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach build-geckolib` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20556
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20674)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented May 18, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2018

⌛ Testing commit c2fb588 with merge 10840a5...
bors-servo added a commit that referenced this pull request May 19, 2018
@bors-servo
Auto merge of #20674 - simartin:issue_20556, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
10840a5 
Issue #20556: Implement proper checks in WebGLRenderingContext's bindBuffer()

Implement missing check, about deleted buffers.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach build-geckolib` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20556
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20674)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2018

💔 Test failed - mac-rel-wpt1
@jdm
Copy link
Member

jdm commented May 19, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2018

⌛ Testing commit c2fb588 with merge cb764be...
bors-servo added a commit that referenced this pull request May 19, 2018
@bors-servo
Auto merge of #20674 - simartin:issue_20556, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cb764be 
Issue #20556: Implement proper checks in WebGLRenderingContext's bindBuffer()

Implement missing check, about deleted buffers.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach build-geckolib` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20556
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20674)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing cb764be to master...
@bors-servo bors-servo merged commit c2fb588 into servo:master May 19, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@simartin simartin deleted the simartin:issue_20556 branch May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Properly implement WebGLRenderingContext.bindBuffer checks
7 participants
@simartin @highfive @nox @bors-servo @gootorov @jdm @emilio
You can’t perform that action at this time.