Implement Window.open and related infrastructure #20678

gterzian · 2018-04-22T07:45:42Z

Implement https://html.spec.whatwg.org/multipage/window-object.html#window-open-steps and related infra...

./mach build -d does not report any errors
./mach build-geckolib does not report any errors
./mach test-tidy does not report any errors
These changes fix #20673 fix #13241 fix #20887 fix #20713 (github issue number if applicable).

There are tests for these changes OR
These changes do not require tests because _____

This change is

highfive · 2018-04-22T07:45:47Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/htmlanchorelement.rs
@fitzgen: components/script/dom/htmlanchorelement.rs
@KiChjang: components/script/dom/htmlanchorelement.rs

highfive · 2018-04-22T07:45:48Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

servo-wpt-sync · 2018-04-22T09:05:22Z

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#51.

servo-wpt-sync · 2018-04-22T09:06:34Z

No upstreamable changes; closed existing PR.

Completed upstream sync of web-platform-test changes at jdm/web-platform-tests#51.

gterzian · 2018-04-23T06:09:52Z

This one is now ready for review.

A few notes:

Why return a Window from choose_browsing_context? Because although we are choosing a browsing context, it is for the purpose of accessing the capabilities of the related window(such as navigation)
Why put choose_browsing_context on WindowProxy? Because it seems that it has all the info necessary for choosing a browsing context.

gterzian · 2018-04-27T04:52:17Z

@bors-servo try

bors-servo · 2018-04-27T04:52:18Z

@gterzian: 🔑 Insufficient privileges: and not in try users

cbrewster · 2018-04-27T04:56:35Z

@bors-servo try

Sorry homu has to be restarted before it takes the new changes into effect.

bors-servo · 2018-04-27T04:56:40Z

⌛ Trying commit 32095f4 with merge ad4c78e...


        Auto merge of #20678 - gterzian:improve_follow_hyperlinks, r=<try>

Implement "the rules for choosing a browsing context"  Implement https://html.spec.whatwg.org/multipage/browsers.html#the-rules-for-choosing-a-browsing-context-given-a-browsing-context-name and plug into 1. https://html.spec.whatwg.org/multipage/links.html#following-hyperlinks 2. https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#concept-form-submit ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach build-geckolib` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #20673 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20678)

bors-servo · 2018-04-27T05:14:37Z

💔 Test failed - linux-rel-css

gterzian · 2018-08-10T23:15:55Z

@jdm OK those were indeed too quickly set to PASS, I've set them back to FAIL...

{"status": "FAIL", "group": "default", "message": "assert_array_equals: Pages opened during history navigation property 1, expected 3 but got 2", "stack": "start_test_wait</timer<@http://web-platform.test:8000/html/browsers/history/the-history-interface/traverse_the_history_2.html:17:13\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1553:20\nTest.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1577:20\n", "subtest": "Multiple history traversals, last would be aborted", "test": "/html/browsers/history/the-history-interface/traverse_the_history_2.html", "line": 84689, "action": "test_result", "expected": "PASS"}
{"status": "FAIL", "group": "default", "message": "assert_array_equals: Pages opened during history navigation property 1, expected 5 but got 3", "stack": "start_test_wait</timer<@http://web-platform.test:8000/html/browsers/history/the-history-interface/traverse_the_history_4.html:17:13\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1553:20\nTest.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1577:20\n", "subtest": "Multiple history traversals, last would be aborted", "test": "/html/browsers/history/the-history-interface/traverse_the_history_4.html", "line": 119587, "action": "test_result", "expected": "PASS"}

while this looks like an intermittent

{"status": "FAIL", "group": "default", "message": "assert_equals: expected \"href\" but got \"click\"", "stack": "onmessage<@http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/006.html:14:5\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1553:20\nTest.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1577:20\n", "subtest": "Link with onclick form submit and href navigation ", "test": "/html/browsers/browsing-the-web/navigating-across-documents/006.html", "line": 68859, "action": "test_result", "expected": "PASS"}

jdm · 2018-08-10T23:46:19Z

@bors-servo r+

bors-servo · 2018-08-10T23:46:19Z

📌 Commit e784f5a has been approved by jdm

bors-servo · 2018-08-10T23:46:24Z

⌛ Testing commit e784f5a with merge 9c24c16...


        Auto merge of #20678 - gterzian:improve_follow_hyperlinks, r=jdm

Implement Window.open and related infrastructure  Implement https://html.spec.whatwg.org/multipage/window-object.html#window-open-steps and related infra... ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach build-geckolib` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #20673 fix #13241 fix #20887 fix #20713 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20678)

bors-servo · 2018-08-11T00:00:52Z

💔 Test failed - linux-rel-css

jdm · 2018-08-11T02:14:04Z

@bors-servo retry

bors-servo · 2018-08-11T02:14:07Z

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-css...

bors-servo · 2018-08-11T02:28:40Z

💔 Test failed - linux-rel-css

CYBAI · 2018-08-11T02:44:21Z

@bors-servo retry

bors-servo · 2018-08-11T02:44:23Z

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-css...

bors-servo · 2018-08-11T02:58:59Z

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 9c24c16 to master...

servo-wpt-sync · 2018-08-11T02:59:16Z

Error syncing changes upstream. Logs saved in error-snapshot-1533956366317.

paulrouget · 2018-08-11T09:46:01Z

\o/


        implement opener, disowning

Upstreamed from servo/servo#20678 [ci skip]

highfive assigned nox Apr 22, 2018

highfive added the S-awaiting-review label Apr 22, 2018

gterzian changed the title ~~[WIP] Improve spec compliance of "follow hyperlinks"~~ [WIP] Implement "the rules for choosing a browsing context" Apr 22, 2018

servo-wpt-sync mentioned this pull request Apr 22, 2018

[WIP] Implement "the rules for choosing a browsing context" jdm/web-platform-tests#51

Closed

gterzian force-pushed the gterzian:improve_follow_hyperlinks branch from 6a2d887 to bc26359 Apr 22, 2018

gterzian force-pushed the gterzian:improve_follow_hyperlinks branch 6 times, most recently from 1bd9f3a to f594279 Apr 23, 2018

gterzian changed the title ~~[WIP] Implement "the rules for choosing a browsing context"~~ Implement "the rules for choosing a browsing context" Apr 23, 2018

gterzian force-pushed the gterzian:improve_follow_hyperlinks branch from dc94a69 to 4b2b6e8 Apr 23, 2018

gterzian force-pushed the gterzian:improve_follow_hyperlinks branch 4 times, most recently from cb33891 to 32095f4 Apr 23, 2018

gterzian mentioned this pull request Apr 27, 2018

Give gterzian try privileges servo/saltfs#825

Merged

highfive added the S-tests-failed label Apr 27, 2018

highfive added S-awaiting-merge and removed S-awaiting-review labels Aug 10, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Aug 11, 2018

highfive added the S-tests-failed label Aug 11, 2018

bors-servo merged commit e784f5a into servo:master Aug 11, 2018
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

This was referenced Aug 11, 2018

Replace mpsc with crossbeam-channel #21325

Merged

Fix the build for NLL #21356

Merged

[WIP] Generic script crate #21371

Open

gterzian deleted the gterzian:improve_follow_hyperlinks branch Aug 11, 2018

jdm added a commit to web-platform-tests/wpt that referenced this pull request Aug 13, 2018

implement opener, disowning

df0680b

Upstreamed from servo/servo#20678 [ci skip]

servo-wpt-sync mentioned this pull request Aug 13, 2018

implement opener, disowning web-platform-tests/wpt#12437

Merged

jdm mentioned this pull request Dec 20, 2018

Implement browsing context targetting for HTMLAreaElement #22515

Closed

servo / servo

Implement Window.open and related infrastructure #20678

Implement Window.open and related infrastructure #20678

gterzian commented Apr 22, 2018 •

edited

highfive commented Apr 22, 2018

highfive commented Apr 22, 2018

servo-wpt-sync commented Apr 22, 2018

servo-wpt-sync commented Apr 22, 2018

gterzian commented Apr 23, 2018 •

edited

gterzian commented Apr 27, 2018

bors-servo commented Apr 27, 2018

cbrewster commented Apr 27, 2018

bors-servo commented Apr 27, 2018

bors-servo commented Apr 27, 2018

gterzian commented Aug 10, 2018 •

edited

jdm commented Aug 10, 2018

bors-servo commented Aug 10, 2018

bors-servo commented Aug 10, 2018

bors-servo commented Aug 11, 2018

jdm commented Aug 11, 2018

bors-servo commented Aug 11, 2018

bors-servo commented Aug 11, 2018

CYBAI commented Aug 11, 2018

bors-servo commented Aug 11, 2018

bors-servo commented Aug 11, 2018

servo-wpt-sync commented Aug 11, 2018

paulrouget commented Aug 11, 2018

servo / servo

Join GitHub today

Implement Window.open and related infrastructure #20678

Implement Window.open and related infrastructure #20678

Conversation

gterzian commented Apr 22, 2018 • edited

highfive commented Apr 22, 2018

highfive commented Apr 22, 2018

servo-wpt-sync commented Apr 22, 2018

servo-wpt-sync commented Apr 22, 2018

gterzian commented Apr 23, 2018 • edited

gterzian commented Apr 27, 2018

bors-servo commented Apr 27, 2018

cbrewster commented Apr 27, 2018

bors-servo commented Apr 27, 2018

bors-servo commented Apr 27, 2018

gterzian commented Aug 10, 2018 • edited

jdm commented Aug 10, 2018

bors-servo commented Aug 10, 2018

bors-servo commented Aug 10, 2018

bors-servo commented Aug 11, 2018

jdm commented Aug 11, 2018

bors-servo commented Aug 11, 2018

bors-servo commented Aug 11, 2018

CYBAI commented Aug 11, 2018

bors-servo commented Aug 11, 2018

bors-servo commented Aug 11, 2018

servo-wpt-sync commented Aug 11, 2018

paulrouget commented Aug 11, 2018

gterzian commented Apr 22, 2018 •

edited

gterzian commented Apr 23, 2018 •

edited

gterzian commented Aug 10, 2018 •

edited