Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Don't clean nightlies on Mac builds" #20695

Merged
merged 1 commit into from Apr 27, 2018
Merged

Revert "Don't clean nightlies on Mac builds" #20695

merged 1 commit into from Apr 27, 2018

Conversation

@nox
Copy link
Member

nox commented Apr 26, 2018 •
edited by SimonSapin

Lars is back to kill servo-mac5 so this can come back.

This reverts commit d52011c.

This change is Reviewable
@nox
Revert "Don't clean nightlies on Mac builds"
Loading status checks…
2d1938b 
Lars is back to kill servo-mac5 so this can come back.

This reverts commit d52011c.
@highfive
Copy link

highfive commented Apr 26, 2018

Heads up! This PR modifies the following files:
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Apr 26, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2018

📌 Commit 2d1938b has been approved by larsbergstrom
@highfive highfive assigned larsbergstrom and unassigned glennw Apr 26, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2018

⌛ Testing commit 2d1938b with merge d645ac5...
bors-servo added a commit that referenced this pull request Apr 26, 2018
@bors-servo
Auto merge of #20695 - servo:cleanup-crew, r=larsbergstrom
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d645ac5 
Revert "Don't clean nightlies on Mac builds"

Lars is back to kill servo-mac5 so this can come back.

This reverts commit d52011c.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20695)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 26, 2018

💔 Test failed - mac-rel-wpt2
@KiChjang
Copy link
Member

KiChjang commented Apr 27, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2018

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2018

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: larsbergstrom
Pushing d645ac5 to master...
@bors-servo bors-servo merged commit 2d1938b into master Apr 27, 2018
3 of 5 checks passed
3 of 5 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
Tidelift Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the cleanup-crew branch Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@larsbergstrom larsbergstrom

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @highfive @larsbergstrom @bors-servo @KiChjang @glennw
You can’t perform that action at this time.