Issue #20593: Implement proper checks in WebGLRenderingContext's getFramebufferAttachmentParameter(). #20699

simartin · 2018-04-27T08:02:07Z

Add missing input checks.

./mach build -d does not report any errors
./mach build-geckolib does not report any errors
./mach test-tidy does not report any errors
These changes fix #20593
There are tests for these changes

This change is

highfive · 2018-04-27T08:02:12Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/webglrenderingcontext.rs
@fitzgen: components/script/dom/webglrenderingcontext.rs
@KiChjang: components/script/dom/webglrenderingcontext.rs

gootorov · 2018-04-28T09:31:47Z

@bors-servo try

bors-servo · 2018-04-28T09:31:53Z

⌛ Trying commit f3625b8 with merge 2f46c6c...


        Auto merge of #20699 - simartin:issue_20593, r=<try>

Issue #20593: Implement proper checks in WebGLRenderingContext's getFramebufferAttachmentParameter(). Add missing input checks. --- - [X] `./mach build -d` does not report any errors - [X] `./mach build-geckolib` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #20593 - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20699)

bors-servo · 2018-04-28T10:01:30Z

💔 Test failed - linux-rel-wpt

simartin · 2018-05-10T06:54:07Z

Looking into those failures, they seem to be due to a spurious change that rejected DEPTH_STENCIL_ATTACHMENT. PR amended accordingly.

simartin · 2018-05-26T06:40:56Z

Is there anything outstanding from me to get this one integrated? Thanks

jdm · 2018-05-26T11:04:01Z

No. I'm behind in my review queue, sorry.
r? @nox

nox · 2018-05-28T08:14:35Z

tests/wpt/mozilla/tests/mozilla/webgl/getFramebufferAttachmentParameter.html

@@ -0,0 +1,114 @@
+    <!doctype html>


Nit: spaces before the doctype.

Indeed, thanks. Fixing in next iteration.

nox · 2018-05-28T08:14:48Z

tests/wpt/mozilla/tests/mozilla/webgl/getFramebufferAttachmentParameter.html

@@ -0,0 +1,114 @@
+    <!doctype html>
+<meta charset="utf-8">
+<title>getFramebufferAttachmentParameter input type check (issue #20593)</title>


@emilio What do we do for additional WebGL tests?

What do you mean?

You can upstream them to https://github.com/KhronosGroup/WebGL if you think they're useful.

I don't know enough to decide whether they're useful there. Any opinion?

nox · 2018-05-28T08:14:58Z

@bors-servo try


        Auto merge of #20699 - simartin:issue_20593, r=<try>

Issue #20593: Implement proper checks in WebGLRenderingContext's getFramebufferAttachmentParameter(). Add missing input checks. --- - [X] `./mach build -d` does not report any errors - [X] `./mach build-geckolib` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #20593 - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20699)

bors-servo · 2018-05-28T08:15:06Z

⌛ Trying commit a90fc1b with merge da172eb...

bors-servo · 2018-05-28T08:32:30Z

💔 Test failed - mac-dev-unit

jdm · 2018-05-30T20:25:50Z

@bors-servo try

bors-servo · 2018-05-30T20:25:56Z

⌛ Trying commit 27bf459 with merge 4151922...


        Auto merge of #20699 - simartin:issue_20593, r=<try>

Issue #20593: Implement proper checks in WebGLRenderingContext's getFramebufferAttachmentParameter(). Add missing input checks. --- - [X] `./mach build -d` does not report any errors - [X] `./mach build-geckolib` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #20593 - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20699)

jdm · 2018-05-30T22:11:13Z

You will need to run ./mach update-manifest to ensure the manifest reflects the most recent changes to the test file.


        Issue #20593: Implement proper checks in WebGLRenderingContext's getF…

…ramebufferAttachmentParameter().

nox · 2018-06-04T13:55:35Z

@bors-servo try

bors-servo · 2018-06-04T13:55:42Z

⌛ Trying commit 08b193c with merge 5eb99b7...


        Auto merge of #20699 - simartin:issue_20593, r=<try>

Issue #20593: Implement proper checks in WebGLRenderingContext's getFramebufferAttachmentParameter(). Add missing input checks. --- - [X] `./mach build -d` does not report any errors - [X] `./mach build-geckolib` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #20593 - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20699)

bors-servo · 2018-06-04T14:57:54Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True

simartin · 2018-06-16T06:20:56Z

Hi! Is there anything outstanding from me to get this one integrated? Thanks

jdm · 2018-06-16T09:44:41Z

Review ping @nox.

nox · 2018-06-18T13:25:32Z

Still the same issue as before, what do we do about the Khronos tests we change locally?

#20699 (comment)

jdm · 2018-06-18T13:39:33Z

@nox We're not changing any tests locally. Modifying the root webgl directory is fine.

nox · 2018-06-18T13:40:22Z

Ok.

@bors-servo r+

bors-servo · 2018-06-18T13:40:23Z

📌 Commit 08b193c has been approved by nox

bors-servo · 2018-06-18T13:53:54Z

⌛ Testing commit 08b193c with merge ff943a3...


        Auto merge of #20699 - simartin:issue_20593, r=nox

Issue #20593: Implement proper checks in WebGLRenderingContext's getFramebufferAttachmentParameter(). Add missing input checks. --- - [X] `./mach build -d` does not report any errors - [X] `./mach build-geckolib` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #20593 - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20699)

bors-servo · 2018-06-18T14:19:51Z

💔 Test failed - linux-rel-wpt

jdm · 2018-06-18T14:44:17Z

@bors-servo retry

#21067

bors-servo · 2018-06-18T16:01:41Z

⌛ Testing commit 08b193c with merge 1f562af...


        Auto merge of #20699 - simartin:issue_20593, r=nox

Issue #20593: Implement proper checks in WebGLRenderingContext's getFramebufferAttachmentParameter(). Add missing input checks. --- - [X] `./mach build -d` does not report any errors - [X] `./mach build-geckolib` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #20593 - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20699)

bors-servo · 2018-06-18T16:51:49Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing 1f562af to master...

highfive assigned glennw Apr 27, 2018

highfive added the S-awaiting-review label Apr 27, 2018

highfive added the S-tests-failed label Apr 28, 2018

simartin force-pushed the simartin:issue_20593 branch from f3625b8 to c3ccd5a May 10, 2018

highfive removed the S-tests-failed label May 10, 2018

simartin force-pushed the simartin:issue_20593 branch from c3ccd5a to a90fc1b May 10, 2018

jdm assigned jdm and unassigned glennw May 19, 2018

highfive assigned nox and unassigned jdm May 26, 2018

nox reviewed May 28, 2018

View changes

highfive added the S-tests-failed label May 28, 2018

simartin force-pushed the simartin:issue_20593 branch from a90fc1b to 27bf459 May 30, 2018

highfive removed the S-tests-failed label May 30, 2018

Issue #20593: Implement proper checks in WebGLRenderingContext's getF…

Loading status checks…

08b193c

…ramebufferAttachmentParameter().

simartin force-pushed the simartin:issue_20593 branch from 27bf459 to 08b193c May 31, 2018

highfive removed the S-tests-failed label May 31, 2018

highfive added S-awaiting-merge and removed S-awaiting-review labels Jun 18, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Jun 18, 2018

highfive added S-awaiting-merge and removed S-tests-failed labels Jun 18, 2018

bors-servo merged commit 08b193c into servo:master Jun 18, 2018
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Jun 18, 2018

simartin deleted the simartin:issue_20593 branch Jun 19, 2018

servo / servo

Issue #20593: Implement proper checks in WebGLRenderingContext's getFramebufferAttachmentParameter(). #20699

Issue #20593: Implement proper checks in WebGLRenderingContext's getFramebufferAttachmentParameter(). #20699

simartin commented Apr 27, 2018 •

edited by SimonSapin

highfive commented Apr 27, 2018

gootorov commented Apr 28, 2018

bors-servo commented Apr 28, 2018

bors-servo commented Apr 28, 2018

simartin commented May 10, 2018 •

edited

simartin commented May 26, 2018

jdm commented May 26, 2018

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

nox commented May 28, 2018

bors-servo commented May 28, 2018

bors-servo commented May 28, 2018

jdm commented May 30, 2018

bors-servo commented May 30, 2018

jdm commented May 30, 2018

nox commented Jun 4, 2018

bors-servo commented Jun 4, 2018

bors-servo commented Jun 4, 2018

simartin commented Jun 16, 2018

jdm commented Jun 16, 2018

nox commented Jun 18, 2018

jdm commented Jun 18, 2018

nox commented Jun 18, 2018

bors-servo commented Jun 18, 2018

bors-servo commented Jun 18, 2018

bors-servo commented Jun 18, 2018

jdm commented Jun 18, 2018

bors-servo commented Jun 18, 2018

bors-servo commented Jun 18, 2018

servo / servo

Join GitHub today

Issue #20593: Implement proper checks in WebGLRenderingContext's getFramebufferAttachmentParameter(). #20699

Issue #20593: Implement proper checks in WebGLRenderingContext's getFramebufferAttachmentParameter(). #20699

Conversation

simartin commented Apr 27, 2018 • edited by SimonSapin

highfive commented Apr 27, 2018

gootorov commented Apr 28, 2018

bors-servo commented Apr 28, 2018

bors-servo commented Apr 28, 2018

simartin commented May 10, 2018 • edited

simartin commented May 26, 2018

jdm commented May 26, 2018

This comment has been minimized.

nox May 28, 2018

This comment has been minimized.

simartin May 30, 2018

This comment has been minimized.

nox May 28, 2018

This comment has been minimized.

jdm May 28, 2018

This comment has been minimized.

emilio May 28, 2018

This comment has been minimized.

simartin May 30, 2018

nox commented May 28, 2018

bors-servo commented May 28, 2018

bors-servo commented May 28, 2018

jdm commented May 30, 2018

bors-servo commented May 30, 2018

jdm commented May 30, 2018

nox commented Jun 4, 2018

bors-servo commented Jun 4, 2018

bors-servo commented Jun 4, 2018

simartin commented Jun 16, 2018

jdm commented Jun 16, 2018

nox commented Jun 18, 2018

jdm commented Jun 18, 2018

nox commented Jun 18, 2018

bors-servo commented Jun 18, 2018

bors-servo commented Jun 18, 2018

bors-servo commented Jun 18, 2018

jdm commented Jun 18, 2018

bors-servo commented Jun 18, 2018

bors-servo commented Jun 18, 2018

simartin commented Apr 27, 2018 •

edited by SimonSapin

simartin commented May 10, 2018 •

edited